jpatrickdill / roblox-requests

The simple, elegant way to send HTTP requests in Roblox.

Hi 👋, I'm Patrick.

Developer from Atlanta creating tools for Roblox & The Metaverse

• 👨‍💻 My portfolio is available at https://paric.dev

• 📫 How to reach me [email protected]

Connect with me:

Languages and Tools:

 

roblox-requests's Issues

multipart/form-data includes one too many \r\n

Describe the bug
FormData:build() (in form.lua) builds the multipart/form-data content_type with just one too many \r\n beteen each part.

To Reproduce
Send a POST request using a FormData object which includes a File object so multipart/form-data is used. See this example code that uses https://httpbin.org/anything (echos back data about the request):

-- Two similar requests, however the latter also sends a file
print(http.post("https://httpbin.org/anything", {
	data = http.FormData({
		hello = "Hello, world";
	});
}):json())
print(http.post("https://httpbin.org/anything", {
	data = http.FormData({
		hello = "Hello, world";
		a_random_file = http.File("hello.txt", "Hello, world in a file", "\n");
	})
}):json())

Example results from Roblox Studio's Output window. Observe the "form" JSON key returned by httpbin - the "hello" key in the second request which includes a file has a preceding newline character. Oh dear!

  Baseplate auto-recovery file was created - C:/Users/Ozzy/Documents/ROBLOX/AutoSaves
  [http] 200 OK | POST https://httpbin.org/anything ( 0.1% ratelimit ) - request:204
   ▼  {
    ["args"] = {},
    ["data"] = "",
    ["files"] = {},
    ["form"] =  ▼  {
       ["hello"] = "Hello, world"
    },
    ["headers"] =  ▶ {...},
    ["method"] = "POST",
    ["origin"] = "23.121.92.239",
    ["url"] = "https://httpbin.org/anything"
  } - Script:31
  [http] Encoding B64 chunk 1/1 - b64:54
  [http] 200 OK | POST https://httpbin.org/anything ( 0.2% ratelimit ) - request:204
   ▼  {
    ["args"] = {},
    ["data"] = "",
    ["files"] =  ▶ {...},
    ["form"] =  ▼  {
       ["hello"] = "
Hello, world"
    },
    ["headers"] =  ▶ {...},
    ["method"] = "POST",
    ["origin"] = "23.121.92.239",
    ["url"] = "https://httpbin.org/anything"
  } - Script:37

Expected behavior
We expect the form data sent (and thereby echoed by httpbin) to not include any extra content we didn't actually send.

Screenshots
The output from above as viewed from Roblox Studio's Output window.
https://i.imgur.com/zCAMTaa.png

Additional context
Methinks this was just a small typo. Gonna submit a PR which removes the extra 2 bytes in the string on line 163 and fixes the issue momentarily.

Using deprecated method

In init.lua, Line 67, promise_send should be promise_request