joshuacrewe / library

Move to : https://codeberg.org/JoshuaCrewe/library

This repo has moved to https://codeberg.org/JoshuaCrewe/joshuacrewe

library's Issues

Data collection should not be in the controller

It should be in a model.

Create a model which will handle all the data manipulation. Normally this would be an eloquent model fetching data from the database. We have no database as we are dealing with data from another site so we will create the methods for this.

$book->all()
$book->get()

Something like that?

Set max number of results

The default to return is 10 items in a list. By adding &max=12 to the query we can choose how many to get.

Pagination is handled with &offset=12 FYI

App doesn't redrawer on browser back button

1. go to home page with search form
2. Make a search
3. Click the back button

The app should clear the search and show the home page again. Similarly refreshing the back and clicking the back button to get the search results URL should show the search results.

Handle errors

At the moment the spinning wheel just never leaves. It would be useful to have some sort of log available to see errors. The front end should feedback with a polite message that the site has gone wrong.

Consider implementing an autocomplete on the search

This will likely hammer the source material a bit but would be nice to have results come up when typing.

Back button doesn't remember search

1. Search for a book
2. Click on a result to see the single page
3. Click the back button on the browser
4. Search is empty no results.

We should save the current search I would think ... ?

Searches with a space causes an error

SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

Fresh install of the app. composer install and yarn install && yarn watch .

Enter a single word and get results. Enter more than one word and get an error.

I like these things ...

Font: https://rsms.me/inter
Router https://github.com/ItalyPaleAle/svelte-spa-router

Search input focus state

When focussing (on ios?) the blue outline does not line up with the border of the box.

Smart quotes break search

From Alpha tester :

Load app on ios.
Search for "Don't be evil"
Wait forever as it always loads

It looks like ios is adding a smart (curly) quote which is breaking things.

Add data from logged in session

In order to reserve books via this interface we are going to have to be able to use the Library Membership Number form (https://capitadiscovery.co.uk/cornwall/login). I suspect that this form will set a cookie enabling access to other areas of the site.

We will need a way of saving this information to use in future requests of the web scraper. I am not sure if this is even possible at this stage.

https://symfony.com/doc/current/components/browser_kit.html#cookies

Feature Requests

• Add to list button prominent (when logged in)
• Smooth sensible content transitions
• Help page. A page to showcase all the search terms
• Icon for ios homecreen
• Short blurb on the archive page?
• Search bar always present (move Search.svelte out of router)
• Back button from a item page
• Click author to search for that author
• Lazy load images ?

Entering in no search result in app error

1. Search for something.
2. Clear the content of the search bar
3. Search again
4. Console error and forever spinning