joshpensky / dinner-finder

Helping you and your S.O. finally pick a restaurant

Dinner Finder

Helping you and S.O. finally pick a restaurant

• Dinner Finder
  • Getting started
    • Dependencies
    • Environment
  • Project directory

Getting started

Dependencies

Please follow the links below to install the required dependencies on your local machine:

• node.js
• npm

After installing these, you will need to install some global dependencies using the following command:

$ npm i -g concurrently nodemon

Environment

Clone this repository onto your local machine. In the root directory of the folder, install the dependencies:

$ npm i

Next, you're going to want to set up a local instance of the project running in a server. To do so, run the following command:

$ npm run dev

You should now be able to visit localhost:3000 in your browser and begin development!

Project directory

dinner-finder's Issues

iOS keyboard overlays the Menu Items text field

When selecting the Menu Items text field on a restaurant edit or new page, the iOS keyboard overlays on top of the text field, preventing users from seeing what they're typing.

This is most likely caused by the page not having enough padding on the bottom.

Steps to reproduce:

1. Click on the add restaurant page
2. Scroll to the bottom of the page
3. Tap on the menu items text field

Add unsaved changes alert

When navigating away from editing or creating an element, there should be an alert or modal that asks users if they want to navigate away even though there are unsaved changes they've made. If they continue, they will be navigated away; otherwise, they can continue editing.

Removing or editing photo doesn't delete the file in GCS

Deleting a restaurant, or changing/deleting the cover photo doesn't delete the photo from Google Cloud Storage.

Steps to recreate:

1. Delete a restaurant
2. Check Google Cloud Storage, see related photo isn't deleted

Saving edits to a restaurant will present a "don't leave, changes not saved" dialog

When trying to edit a restaurant and save changes, before it redirects to a new page it asks: You have unsaved changes. Are you sure you want to leave?

This is most likely caused by the condition to show the dialog does not check if the save button is pressed before leaving.

Steps to reproduce:

• Click on the edit button on an existing restaurant page
• Edit one of the fields
• Tap on the save button

Modal text doesn't match the context of the item

No matter which restaurant you are deleting, it will always ask if you want to delete "Amelia's Taqueria".

Steps to reproduce:

1. Open a restaurant detail page
2. Click on the edit button
3. Click on the delete button

Delivery flag

Add a boolean flag to a restaurant object that lets you know if you the food can be delivered or not.

Menu items drag-and-drop

When creating or editing a restaurant, the menu items should be able to be rearranged via drag-and-drop.

Can't remove cover photo in edit

When on the edit page for a restaurant, clearing an existing photo will not remove it upon submission.

Steps to recreate:

1. Create a new restaurant with a cover photo or visit an existing one.
2. Click the edit button
3. Click the clear button under the cover photo input
4. Click submit

Missing form errors

The create and edit forms have validation checks, but there are no errors displayed when an error occurs.