joshhunt / destinysets

Destiny Sets

Getting started

Just want to update the set data? You can skip this party

Prerequisites:

• A fairly recent installation of Node - I use v8.9.3
• Able to use Terminal/bash

1. Copy .env.local-sample to .env.local and fill in REACT_APP_BUNGIE_CLIENT_ID and REACT_APP_API_KEY with your Bungie.net OAuth client_id and API Key (see below for how to get these)

2. Install dependencies with npm install (or yarn install if you have Yarn)

3. Run the local dev server with npm start (or yarn start if you have Yarn)

4. You should see "Compiled successfully!", with instructions, and the site should open in your browser.

   • Note, as we're using HTTPS locally with a self-signed certificate, you'll get a security warning. You'll need to 'proceed anyway' to continue.

How to contribute to the set data

1. Open the appropriate data file in src/setData
2. Look at the structure of the data - it reflects the layout of each page on the site. Ultimately, items on the pages are specified in the items array, by their item hash (ID).
3. Search for an item on the Data Explorer page on DestinySets.com, click the item and copy the hash - the number in the little box next to the item's name in the overlay.
   • e.g. The hash for "Contender's Shell" is 113124080.
4. Paste the hash into the appropriate items array in the data file you're making the change to. Just make sure you keep the syntax valid, observing commas, etc. It's also nice to include the little // item name comment at the end of each line to make it easier for the next person
5. Save the file and Submit the pull request via Github 🎉

If you're adding multiple items in one set, the Data Explorer has a special mode to make it easier. Click the "Explore the entire Destiny 2 database..." text at the top to enable "Collect Mode". Now, as you click an item it'll appear in the sidebar, automatically categorised, and copied to your clipboard in a format appropriate for the data files.

Getting API Keys from bungie.net

TODO: write this better

1. New app at https://www.bungie.net/en/Application
2. oauth client type: public
3. redirect url: url the site is running at. for dev, this will probably be https://localhost:4000
4. check all scopes, except for "Administrate groups and clans..."
5. Origin Header: if it's just a key for local development, just enter * here

destinysets's Issues

Search for items (ctrl + f)

There's no item names on the page, so ctrl + F doesn't work. I've already tried an alternate page design to allow browser search to work, but its just not very functional.

Instead, lets add in a little expando search field and use the existing filter functionality to search through the items on the page.

https://twitter.com/StopShulking/status/960242171298299905

Tooltip unable to be closed on mobile

https://twitter.com/Jadd/status/917556603892748288

Retro-Grade TG2 should be in same line with Heiro Camo + Dead End Cure 2.1

Hello,

It looks to me that

Dead End Cure 2.1 + Retro-Grade TG2 + Heiro Camo [Share same design theme]

and

Errant Knight 1.0 + Kerak Type 2 + Philomath [Share same design theme]

I would suggest to interchange the Kerak Type 2 with Retro-Grade TG2 as they share same design theme (Red)

Legend of Acrius twice in the exotic in the "all" tab

Collectors probably care about getting the final version, and don't care about the first version without perks. I think both these entries should be converged into one.

PS4 exclusives listed when using an xbox account

I know for sure that the exotic Borealis is a PS4 exclusive but it shows up for me as an xbox user.
I would not bring this up except that I believe there are full armor sets exclusive to PS4 which are not shown so I'm assuming you are already filtering those out for xbox.

Eystein-D shows up under All Items, but is missing from Base.

Feature: All Seasons Tab

A tab filter that displays both "Base" and "Curse of Osiris" (and future DLCs) using the grouped layout of those tabs. The DLC icons on the item icons already identify what DLC they are from. DLC filters will probably need to be put into a dropdown as there is already "Curse of Osiris" and "The Dawning".

[Suggestion] Grouping weapons by weapon class.

Hello Josh,

I use your site a lot to keep track of my items progress, so first of all, thanks for great job done and here's a suggestion, that I personally miss a lot: ability to view weapons, grouped by weapon class (all auto-rifles grouped together, all hand cannons, etc).

How this can be helpful:

• If I have all sniper-rifles and all of them are 305 already, I'll probably dismantle 300 blues and legendary ones. If I miss one, Ill know and will be able to save one duplicate for infuse.
• Knowing that you have most\all weapons in a class collected, actually allows you to go test them all to, perhaps, pick up the alternative to the current one and spend mods on it.

Thanks in advance.

[Request] Exotic Ornaments and Hiding Items

Please would it be possible to add the Exotic Ornaments to the "All Items" page.

On the "Sets" page would it please be possible to hide items you do not want to collect. For instance my Hunter is with FWC, Warlock with NM and Titan with DO, i have no intention of ever changing that so i will never get the other armor sets with each of them, however it will keep showing as not collected. Using the filters to mark items as hidden or unhidden would be useful. These filters could work on the "All Items" page too.

Thanks.

missing sets

this is just one set that is missing, but the icarus drifter set for the hunter is missing from the sets that can be found. anyone know of any others?

Some weapons are missing to faction weapon list.

Eystein-D: EDZ
First In, Last Out: Arcology
The Mornin' Comes: Nessus
Death Adder: Io
is included in each faction engram table, but not included in the site.

You can check each list on Data Explorer with EDZ engram, Arcology engram, Nessus engram, IO engram

Legend of Acrius listed twice

Github description contains wrong URL

Just a heads up.

Is currently https://destinyitem.com should probably be https://destinysets.com

[Request] Keep track of past items you acquired.

I know you can't see what items players have had in the past before authorising the site to read their account, but you could have it that once it detects an item in the player's inventory, it would add that item to a list of acquired items and then mark it as acquired on the site. It would be a perfect addition to the site as im sure everyone wants this. I've already seen multiple requests for this.

One other side request:
If possible, could you make a way to share your inventory? Like a URL you could generator to send to your friends, like DIM or Ishtar (I cant remember which one, or if it's even either one of them) did for Destiny 1?

Bug: Ornaments not being filtered

Armor ornaments aren't being affected by the filters.

[Suggestion] Move Trials of the Nine Set to "Endgame"

Makes more sense, no? Might be a quick fix since you are already thinking of reorganizing the page.

The collected filter does not appear to be working

Checked or unchecked nothing changes. Collected items are always shown.

Show tracked stats on emblems

Show tracked stats on emblems in the item tooltip

Example

Add indicator that items are filtered

It's not immediately obvious that items, like the PS4 exclusives, are filtered out. See #20

An indicator somewhere on the page could help with this.

Eystein-D pulse rifle not listed in EDZ

Apparently the Eystein-D pulse rifle should be in EDZ gear.

https://twitter.com/zavalaluvsme/status/918235733558665216

Season 2?

VERY NICE JOB on this!!

What are your plans to reflect any season 2 armor/weapon changes?

Filters should be available when scrolled down

Maybe a sticky header would be useful for having access to filters from anywhere on page

Exotic Armor and Weapons are not displayed

Exotic Armor and Weapons are missing :(

Use Popper.js?

https://github.com/FezVrasta/popper.js

Feature: Accordion style controls on Activity Wrappers that persist across page loads.

When a collection is complete or irrelevant to what a player wants to collect, it'd be nice to be able to minimize/hide sections to free up screen space.

Issue connecting to bungie.net

Last night I received at least 3 items i didn't previously have. When I checked destinysets they still showed as missing. I tried refresh but no help. Tried deleting cookies and added my xbox account again but now everything shows as unfound. Tried a different browser and also everything unfound.

[Feature] Additional filter / Visual mark for duplicated items.

I would be nice to show duplicated items only, to know what can be safely dismantled or used as infusion fuel.

Additionally, each item can have some sort of visual mark to indicate that it is duplicated. As Destiny 2 does not have random rolls (thank you Bungie!) and modifiers are easily available - there is no need to keep more than 1 copy of each item.

Feature idea: Show newly acquired items.

I realize this one might be a little tougher since it would require storing data...

After a playing session I like to check the site to see if I picked up any new items. This isn't easy to keep track of because I have to remember everything I was missing. It would be really cool if the site could highlight any newly acquired items since the last visit or last day, etc.

Feature: No Dawning items in Base or CoO

The only place the Dawning items appear is the the "All Sets". It should be in one of the Eververse sections.

Stuck at black loading screen.

Stuck at a black screen with "loading ..." in the middle of it. Website opens, menu bar shows on top, but no items load. It is the same on iPhone, iPad, and PC. Does not matter if using Internet Explorer, Google Chrome or Safari. All OS's are up to date.

Unable to log out

There's no logout functionality on the site. There should be.

Exotic Ornaments not recording properly in Google Drive.

I have pretty well all the exotics and their ornaments. The ornament section is only recording a small amount of the ornaments I have currently equipped and or deleted. If I purchase a deleted exotic from the vault/kiosk I can equip the ornament, refresh Destiny Sets and it then shows I have it. If I delete that exotic and refresh, there is no record in DS. As the sample in the image shows, it is working (recording in Google Drive) for some but not others.

To name a few, I have the ornaments for Sunshot, Fighting Lion and Cold Heart but not showing as Dismantled like the Vulcans Heart ornament

Consolidate ornaments

Is there any chance the ornament section could be reworked? For example, the trials ornament is only shown on my hunter, but should be unlocked on all. Probably different items in API, but maybe consolidate Hunter/Warlock/Titan ornaments?

https://twitter.com/itsnotunusual_r/status/961036554574573570

Not all emblems showing owned

There may be others, however I am sure I have the following emblems but Destiny Sets not showing that I do.
The First Wave
Emperor's Shadows
In The Fire
Resonant Chord
Stand Together
Push Forward
The Consensus
Kadi 55-30's Blessing (I'm pretty sure but will need to double check)

Debug info: https://gist.github.com/joshhunt/5d398e31a51ad8f5576eaec0c118662f

Maybe not a bug?

I notice in ghost section there are duplicates. Is this a bug or am I missing something?

[Suggestion] Show full set when hovering over name

Easier viewing the whole set together as opposed to mentally piecing it together.
Rough mockup

Feature Idea: Ghost Shells - show what location they roll perks for.

The bottom of the first post here details them. It would be so much easier if this was built into this app rather than referencing this reddit post.

https://ns.reddit.com/r/DestinyTheGame/comments/75j2ol/ghost_shell_list_by_type_and_location_with_perk/

I know... not really what this was designed for but it would sure be helpful.

Design it not optimal on monitors people use the site on

The most popular resolution people use Destiny Sets with is a whopping 1920x1080, and Destiny doesn't really scale that well to a resolution that size, but it should!

At an absolute minimum, columns should flex to fill the available screen width.

Filter syntax inconsistent

Perhaps nitpicking...

Checking the boxes for Warlock, Hunter and Titan SHOWS items
Checking the box for "Hide collected" HIDES items.

Yes, It's in the name but to me It just seems off that some checkboxes show things and other hide them.

Dawning section does not contain all armour pieces

There is 6 armour pieces available for each class the full winterhart set plus an additional class item for each. Currently only 5 items per class is shown

A suggestion about server costs

Since you're asking people how to handle server costs, I use a site for a different game (Final Fantasy XIV) that asks users for support to maintain server costs since they don't even play the game anymore but update it for the community.

http://ffxiv.ariyala.com/

something simple like that could work, also nothing wrong with Patreon either.

Display item count and percentage collected

Would there be a way we could add the counts for each set and overall gear to each section.
For example:
At the top it would say (77/500) total collected"
Then in the Iron Banner section, next to weapons is say (10/15)
and the same for the armor.

I think this would be a pretty helpful addition.

Feature: Add Weapon Type Slot to Gear Cards

ie Kinetic/Energy/Power.

Having trouble logging out

First of all, let me just say thank you very much for the great app!

Ok, on to the problem, I am logged into my Destiny 2 PC account on Destiny Sets and am unable to log out in order to get to my PS4 account on DS. Thank you in advance for the help.

Borealis not included in PS4 exclusive filter

Title says it all

Vanguard Tactician Gear - ordering

All other groups have armor ordered Hunter, Titan, Warlock. This one is Hunter, Warlock, Titan.

Exotics tracking

Would be nice to have separate collection tab for exotics.

Bug: language selector not working

On Data Explorer tab the language selector is not working. The workaround is to change to another tab, change to the desired language and then change it back to DE...

Include location obtained info

One recommendation that I would give is to add where each item can be obtained. possibly even put recommended areas to look for each item. for example the Icarus Drifter set is best farmed on IO. Why that is I have no idea but that is what a community that I am a part of came to that conclusion.

Tooltip goes off-window for items at edge of screen

Bug in https://github.com/romainberger/react-portal-tooltip, fork and fix.