ESLint CRLF Windows about keen-ui

[JosephusPaye]

Thanks for the PR update.

We've got LF specified in the current .editorconfig already.

[JosephusPaye]

I'm on Windows too, and use the following to ensure only LF is committed:

git config --global core.autocrlf input

So I can checkout and edit in CRLF but all commits are in LF. Though I've setup all my editors to use LF across the board.

[Lewiscowles1986]

While I understand we can ask Git users to change how git works out of the box, I think you'll always have some people unprepared. That would also take any accidental editor differences between projects and enforce them globally. For me it's not a workable solution.

[JosephusPaye]

I think it's possible to do this via a .gitattributes file that enforces it for the repo, without the need for a global config change.

[Lewiscowles1986]

Thanks @JosephusPaye

I've added a .gitattributes file to the repo as part of the PR for this. I still believe the eslint changes are reasonable because the autocrlf behavior is only when checking out and committing.

Perhaps as a follow-up .editorconfig should also be added in a separate PR to ensure not only line-feeds, but other formatting for the project is enforced by supporting IDE's?

[Lewiscowles1986]

Thanks for update. 9dd56b4 looks to me that .gitattributes without .eslintrc edits saves the day.