Add `ui-textbox__input-wrapper` around `ui-textbox__input` and `ui-textbox__textarea` about keen-ui

[JosephusPaye]

Does LastPass add something to the input (like a class or attribute) you could use to adjust the icon position?

I'm hesitant to add this because other browsers (like Edge on Windows) add their own password toggle icon on the input as well.

[entioentio]

I think you've misunderstood me a bit. My intention was not to add the show/hide toggle to every password icon, but to add wrapper which would take over the input's styling (bottom border). That would allow (using some per-implementation CSS trickery) to position an icon over the input. Icon next to the input works well in most cases, but isn't really the best option in the case of password input.

Thus, I thought of proposed changes more like a flexible way for sizing the input. The whole container would still be clickable, as it was inside <label>.

Does LastPass add something to the input (like a class or attribute) you could use to adjust the icon position?

No, it doesn't, and I think it doesn't do that on purpose (disable detection = maximize security).

I'm hesitant to add this because other browsers (like Edge on Windows) add their own password toggle icon on the input as well.

I got your point. However, if I am to develop my own show / hide solution, it kinda lies within my own responsibilities to disable the windows/ie ones; with this for example: https://stackoverflow.com/a/19952071/1660757

[JosephusPaye]

Ah, I see that you mean now. If it's just adding the wrapper you can submit a PR. Then handle the CSS changes locally in your app.

[entioentio]

See PR #490