jonoxia / lovebird Goto Github PK

E.g. if I send a reply to a conversation, while that conversation is currently open in the thread view, I expect the message I just sent to appear at the bottom, but it does not.

Because the list of people is only loaded into memory when the tab opens, and is cleared when it closes.

This is the cause of the "lbTabDocument is null" error given if you click the heart while the tab is not open.

To solve this, lovebird_main.js needs to be refactored to maintain the list of loved contacts even apart fro the tab being open.

user review here: https://addons.mozilla.org/en-US/firefox/addon/lovebird/reviews/434804/
Theme here: https://addons.mozilla.org/en-us/thunderbird/addon/phoenity-shredder/

The message content in Lovebird does not match the actual content in TB. I am not sure why or what yet. I'll try to pinpoint

(add-on installed on AMO in TBird 17.0.3)

When I send a reply to a thread, i suppose my outgoing message is technically "unread" but I don't want the thread to be marked as unread because of it.

Line 137-138 in Convo.addMsg in lovebird_main.js is supposed to handle this case, but I guess it's not working as intended.

Got a warning about this when uploading to AMO.

I think the offending files are mostly Emacs autosave files (e.g. *.js~)

First let me say: I really like the idea behind this add-on! I'm looking forward to see it develop further. Thank you for your work!

Each time I open the Lovebird tab the list of people is unordered, neither »Oldest«, »Unanswered« etc. is chosen. I haven’t been able to figure out what the list is ordered by; it certainly isn’t ordered by one of the options in the toolbar above.

I would like Lovebird to remember which ordering option was active when the tab was closed.

Please let me know if you need more information.

Regards
phofm

LovebirdModule.myEmail is a singular value, but in reality people can have multiple email addresses that they used to send stuff from Thunderbird. Should handle this possibility, replace myEmail with an array, and rewrite any code that assumes it's a single value.

AMO reviewer Leszek Życzkowski said:

1. People's names in the Loverbird list are displayed too big and bolded font.
2. Column ? is too small (icon is truncated)
3. After remove person from Loverbird list all conversations are displayed should be removed

First: Amazing work! Super-props!

createStatement synchronously acquires a mutex on the main thread which can cause the main thread to join on your async database and its I/O. This is very likely not what you want. For statements that will only be used asynchronously, you can/should use createAsyncStatement:
https://mxr.mozilla.org/mozilla-central/source/storage/public/mozIStorageConnection.idl#148

Reported by Leszek Życzkowski
Error message is as follows:

Error: ReferenceError: window is not defined
Source File: resource:///modules/gloda/datastore.js
Line: 387

Error: 2013-02-23 14:59:19 gloda.ds.qfq ERROR Exception: ReferenceError: window is not defined
Source File: resource:///modules/gloda/log4moz.js
Line: 687

• A certain site with a forum uses a separate e-mail address for notifications about each thread. The message authors can be distinguished by the author name.
• I clicked heart on one of the messages (the second one, I think), by author A.
• LoveBird took name B as the author name for the message (probably from the first message), and I am not sure if it shown all three messages, or only the third one, from author C.

It shouldn't be marked as needing reply until I get an incoming message from the other person.

I currently see two instances of the same name in my lovebird contact list, because they're two different email addresses for the same person. I would like to be able to merge them, and have Lovebird maintain a single conversation list, since it's the person I care about, not their email address. When sending to the person, I should ideally get a drop-down menu of which address to send to.

Sometimes when trying to add a person via the "add a person" search box on the Lovebird tab, I get an error message about no identity data being available.

Right now once Thunderbird saves a draft I didn't want, then the unsent draft hangs around forever, and I always see the draft icon next to the person's name. I should have an easy way to discard one/all drafts to a given person.

My intent is for the code to be released under the MPL; should add the MPL boilerplate comment to the top of each source file.

Maybe double-clicking a thread with a draft in it should always resume the draft, even if the draft is not the newest message in the thread?

What about double-clicking a person's name that has the draft status icon next to it? Should that resume the draft?

Maybe a "resume draft" button when a thread with a draft is selected?