jonnitto / jonnitto.prettyembedhelper Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 5.0 1.7 MB

Helper mixins, prototypes and frontend resources for the PrettyEmbed Series

License: GNU General Public License v3.0

JavaScript 27.87% PHP 58.13% SCSS 11.72% Makefile 1.34% CSS 0.95%

hacktoberfest media neoscms package video vimeo youtube

jonnitto.prettyembedhelper's People

Contributors

Stargazers

Watchers

Forkers

marcrobertscamao markusguenther skurfuerst dlubitz so-grimm

jonnitto.prettyembedhelper's Issues

On copy a video node the metadata doesn't get loaded

Describe the bug

If you copy an paste a video node, the metadata get's removed and not newly loaded on the new node.

Expected behaviour

I'd expect to have the video metadata also in the new node.

Steps to reproduce

Add a YT video with correct ID
Apply => You see the preview image
Publish
Copy this node
Paste below => The preview image on the new node is missing

Version

2.2.0

PHP version

8.2

Environment

Additional context

No response

AlpineCheck.js cannot be downloaded in browser

Describe the bug

Hi, thanks for the package :).

When using the jonnitto/prettyembedvideo package, the AlpineCheck.js file cannot be downloaded in the browser, because of a 404 status. This results in a broken video player, with just the cover image being displayed.

Expected behaviour

The AlpineCheck.js file should be accessable to the browser and downloadable.

Steps to reproduce

Create a new video element on a neos page.
Maintain the data for video element (video and cover image)

Version

6.4.1

PHP version

PHP 8.1.27 (cli) (built: Dec 21 2023 20:17:59) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.27, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.27, Copyright (c), by Zend Technologies

Environment

abx/product-api                                 1.0.20
abx/website                                     1.0.0
behat/transliterator                            v1.5.0
brick/math                                      0.11.0
carbon/eel                                      2.12.0
carbon/fileloader                               0.1.4
carbon/notification                             2.4.0
composer/ca-bundle                              1.4.1
composer/class-map-generator                    1.1.0
composer/composer                               2.7.1
composer/metadata-minifier                      1.0.0
composer/pcre                                   3.1.1
composer/semver                                 3.4.0
composer/spdx-licenses                          1.5.8
composer/xdebug-handler                         3.0.3
cweagans/composer-patches                       1.7.3
doctrine/annotations                            1.14.3
doctrine/cache                                  2.2.0
doctrine/collections                            1.8.0
doctrine/common                                 3.4.3
doctrine/dbal                                   2.13.9
doctrine/deprecations                           1.1.3
doctrine/event-manager                          1.2.0
doctrine/inflector                              2.0.10
doctrine/instantiator                           1.5.0
doctrine/lexer                                  2.1.1
doctrine/migrations                             3.4.3
doctrine/orm                                    2.18.1
doctrine/persistence                            3.2.0
egulias/email-validator                         3.2.6
enshrined/svg-sanitize                          0.17.0
eventsauce/object-hydrator                      1.4.0
flowpack/cachebuster                            1.3.0
flowpack/elasticsearch                          5.2.0
flowpack/elasticsearch-contentrepositoryadaptor 8.5.0
flowpack/listable                               3.6.0
friendsofphp/proxy-manager-lts                  v1.0.16
gedmo/doctrine-extensions                       v3.13.0
guzzlehttp/guzzle                               7.8.1
guzzlehttp/promises                             2.0.2
guzzlehttp/psr7                                 2.6.2
imagine/imagine                                 1.3.5
internezzo/childreload                          1.0.2
jonnitto/prettyembedhelper                      6.4.1
jonnitto/prettyembedvideo                       6.2.0
justinrainbow/json-schema                       v5.2.13
laminas/laminas-code                            4.13.0
league/csv                                      9.8.0
masterminds/html5                               2.8.1
matthiasmullie/minify                           1.3.71
matthiasmullie/path-converter                   1.1.3
michelf/php-markdown                            2.0.0
mikey179/vfsstream                              v1.6.11
mireo91/repeatablefields                        v2.2.0
monolog/monolog                                 2.9.2
myclabs/deep-copy                               1.11.1
neos/behat                                      8.3.x-dev 5728095
neos/buildessentials                            6.3.0
neos/cache                                      8.3.8
neos/composer-plugin                            2.1.3
neos/content-repository                         8.3.10
neos/content-repository-search                  4.1.2
neos/diff                                       8.3.10
neos/eel                                        8.3.8
neos/error-messages                             8.3.8
neos/flow                                       8.3.8
neos/flow-log                                   8.3.8
neos/fluid-adaptor                              8.3.8
neos/form                                       5.4.2
neos/form-builder                               2.3.4
neos/form-fusionrenderer                        2.1.2
neos/fusion                                     8.3.10
neos/fusion-afx                                 8.3.10
neos/fusion-form                                v2.2.0
neos/http-factories                             8.3.8
neos/imagine                                    3.3.2
neos/media                                      8.3.10
neos/media-browser                              8.3.10
neos/neos                                       8.3.10
neos/neos-ui                                    8.3.6
neos/neos-ui-compiled                           8.3.6
neos/nodetypes                                  8.3.10
neos/nodetypes-assetlist                        8.3.10
neos/nodetypes-basemixins                       8.3.10
neos/nodetypes-columnlayouts                    8.3.10
neos/nodetypes-contentreferences                8.3.10
neos/nodetypes-form                             8.3.10
neos/nodetypes-html                             8.3.10
neos/nodetypes-navigation                       8.3.10
neos/party                                      7.0.4
neos/redirecthandler                            5.0.3
neos/redirecthandler-databasestorage            5.0.4
neos/redirecthandler-neosadapter                4.3.4
neos/redirecthandler-ui                         2.5.0
neos/seo                                        3.3.4
neos/swiftmailer                                7.3.0
neos/twitter-bootstrap                          3.0.8
neos/utility-arrays                             8.3.8
neos/utility-files                              8.3.8
neos/utility-mediatypes                         8.3.8
neos/utility-objecthandling                     8.3.8
neos/utility-opcodecache                        8.3.8
neos/utility-pdo                                8.3.8
neos/utility-schema                             8.3.8
neos/utility-unicode                            8.3.8
packagefactory/atomicfusion-proptypes           v2.2.0
phar-io/manifest                                2.0.3
phar-io/version                                 3.2.1
phpunit/php-code-coverage                       7.0.15
phpunit/php-file-iterator                       2.0.5
phpunit/php-text-template                       1.2.1
phpunit/php-timer                               2.1.3
phpunit/php-token-stream                        4.0.4
phpunit/phpunit                                 8.5.36
psr/cache                                       3.0.0
psr/container                                   1.1.2
psr/http-client                                 1.0.3
psr/http-factory                                1.0.2
psr/http-message                                1.1
psr/http-server-handler                         1.0.2
psr/http-server-middleware                      1.0.2
psr/log                                         3.0.0
psr/simple-cache                                3.0.0
punktde/eel-arrayhelper                         1.9.0
ralouphie/getallheaders                         3.0.3
ramsey/collection                               2.0.0
ramsey/uuid                                     4.7.5
react/promise                                   v3.1.0
sandstorm/lightweightelasticsearch              v0.5.2
sebastian/code-unit-reverse-lookup              1.0.2
sebastian/comparator                            3.0.5
sebastian/diff                                  3.0.4
sebastian/environment                           4.2.4
sebastian/exporter                              3.1.5
sebastian/global-state                          3.0.3
sebastian/object-enumerator                     3.0.4
sebastian/object-reflector                      1.1.2
sebastian/recursion-context                     3.0.1
sebastian/resource-operations                   2.0.2
sebastian/type                                  1.1.4
sebastian/version                               2.0.1
seld/jsonlint                                   1.10.2
seld/phar-utils                                 1.2.1
seld/signal-handler                             2.0.2
sitegeist/kaleidoscope                          v6.7.0
sitegeist/slipstream                            v2.1.6
swiftmailer/swiftmailer                         v6.3.0
symfony/cache                                   v6.4.4
symfony/cache-contracts                         v3.4.0
symfony/console                                 v6.4.4
symfony/css-selector                            v2.8.52
symfony/deprecation-contracts                   v3.4.0
symfony/dom-crawler                             v6.4.4
symfony/filesystem                              v6.4.3
symfony/finder                                  v6.4.0
symfony/polyfill-ctype                          v1.29.0
symfony/polyfill-iconv                          v1.29.0
symfony/polyfill-intl-grapheme                  v1.29.0
symfony/polyfill-intl-idn                       v1.29.0
symfony/polyfill-intl-normalizer                v1.29.0
symfony/polyfill-php81                          v1.29.0
symfony/polyfill-php83                          v1.29.0
symfony/process                                 v6.4.4
symfony/service-contracts                       v3.4.1
symfony/stopwatch                               v6.4.3
symfony/string                                  v6.4.4
symfony/translation-contracts                   v3.4.1
symfony/validator                               v6.4.4
symfony/var-exporter                            v6.4.4
symfony/yaml                                    v6.4.3
techdivision/ckstyles                           v1.5.1
theseer/tokenizer                               1.2.2
ttree/linkeddata                                dev-master 0b14ecd
typo3fluid/fluid                                2.7.4
yieldstudio/tailwind-merge-php                  0.0.3

Additional context

This should be fixable by moving the alpineJSCheck line from mjs to js in Jonnitto.PrettyEmbedHelper/Resources/Private/Fusion/Helper/Assets.fusion

GdprMessage not working

Describe the bug
The message is never set.

Jonnitto.PrettyEmbedVimeo:Component.Vimeo uses gdprMessage = Jonnitto.PrettyEmbedHelper:GdprMessage, which is already false.

To fix this, the Jonnitto.PrettyEmbedHelper:GdprMessage key should be valueinstead of gdprMessage, see https://github.com/jonnitto/Jonnitto.PrettyEmbedHelper/blob/master/Resources/Private/Fusion/Helper/GdprMessage.fusion#L2

Connecting to the persistence manager during boot throws error if no database is configured

Steps to reproduce:

Create a setup without a database configuration, for example:

Clone https://github.com/neos/neos-base-distribution
Add jonnitto/prettyembedhelper (composer require jonnitto/prettyembedhelper)
Install everything (composer update)
Run server (./flow server:run)

Actual result:

An error occurred in the Database Abstraction Layer.
Type: Neos\Flow\Persistence\Doctrine\Exception\DatabaseException
  File:
Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Flow_Persist
        ence_Doctrine_Query.php
  Line: 210

Open Data/Logs/Exceptions/20201115111045470da1.txt for a full stack
trace.

  Type: Neos\Flow\Core\Booting\Exception\SubProcessException
  Code: 1355480641
  File: Packages/Framework/Neos.Flow/Classes/Core/Booting/Scripts.php
  Line: 699

Open Data/Logs/Exceptions/2020111511104135a448.txt for a full stack trace.

Looking at the trace, Neos tries to execute the following line:
https://github.com/neos/flow-development-collection/blob/00d15c98afdb7a70cb86b2bcf4518bffd64d8252/Neos.Flow/Classes/Core/Booting/Scripts.php#L641
which fails if no database is configured.

Expected result:
The server starts up fine so I can access the setup.

Note: When executing ./flow server:run a second time, the server indeed starts up, but accessing http://127.0.0.1:8081/setup/login does not show the login screen, but the screen directing to the setup instead.

The following line seems to trigger the error (when commenting the line, the error does not occur):

Jonnitto.PrettyEmbedHelper/Classes/Package.php

Line 27 in 0f7259c

    
           $dispatcher->connect(PersistenceManager::class, 'allObjectsPersisted', ImageService::class, 'deletePendingData', false);

IE 11 support

Describe the bug
Tested the package in combination with the package jonnitto/prettyembedyoutube
The package javascript throws some errors in the IE 11.

Saw that my initial error with the constinside the main.js already has been solved.
I did not understand how the public assest will be generated. Therefore just an issue instead of a PR ;)

To Reproduce
Just load a side with the included Main.js in the IE 11.

Expected behavior
No errors in the IE 11

Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser IE 11
Version 1.0.3

tag repository is queried at the end of every request

Describe the bug

At the end of every request Flow triggers allObjectsPersisted which will then trigger the slot of the helper and at some point checks the tag repository for a specific tag.

This is unnecessary as 99,9% of requests are not changing anything there.
And it can cause errors if the persistence manager is already closed for some reason.

To Reproduce

Easy ;)

Expected behavior

If nothing changed related to the tag that needs modification, no further code should run.

Screenshots

n/a

prettyembedMetadataThumbnail is not present if node is copied

Describe the bug

If a Vimeo or YouTube Node get's copied, the prettyembedMetadataThumbnail is not copied.

Expected behaviour

The property should still be filled

Steps to reproduce

Create a YouTube video
Copy it
Check the source

Version

PHP version

8.1.26

No response

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.