jonnii / speakeasy

Making http easy... hopefully.

speakeasy's Issues

GET and other overloads without segments object

HttpResponseState organization

Portable Library

• custom user agents support
• no longer need to specify content length?
• no longer able to specify allow auto redirect?
• update package
• remove all remaining #ifdefs

Add support for uri templates

http://tools.ietf.org/html/rfc6570

Multipart mime content (content refactor)

Async methods need cancellation tokens

Expose HttpResponseHeaders

https://msdn.microsoft.com/en-us/library/system.net.http.headers.httpresponseheaders(v=vs.118).aspx

To enable access to other headers such as Location

Allow configuration of automatic redirects

Add ability to customize how segments are transformed into parameters

Something like this:

client.Get("search", new { perPage = 30 });

Should be transformed into:

search?per_page=30

File Downloads

An easy way to inspect data going over the wire

Pass naming convention down into default json serializer

Add support for handlers for any success/failure codes

Make authorization a middleware and/or setting

Can we add support for writing dictionaries as query string parameters

Hi @jonnii , it would be good to support dictionary like query string parameters, something like this:

var fields = new Dictionary<object, object>()
{
  { "foo": "foo-values" },
  { "bar": "bar-values" }
}

httpClient.Get("authors", new { fields })
// -> translates to "GET ...authors?fields[foo]=foo-values&fields[bar]=bar-values"

The ApiController accepts such query string parameters natively ([FromQuery] Dictionary<string, string> fields), it would be great if speakeasy would support creating the parameters from a dictionary also

API for async callbacks

            return httpClient.PostAsync(new { arguments }, "admin/tasks/:taskName", new { taskName })
                .On(HttpStatusCode.NotAcceptable, handler => throw new InvalidOperationException(handler.AsString()))
                .On(HttpStatusCode.BadRequest, handler => throw new InvalidOperationException(handler.AsString()))
                .OnOk()
                .AsWrapped<T>();

HttpException should have request/response on it

This helps tremendously when debugging.

Remove dependency on newtonsoft.json

Use simple json.

Unit tests for deserializers

Enums

Ensure all specs are uncommented

Deserializing dates fail

Steps to reproduce:

1. Add a DateTime property to the Product class in the Integration Test project and set a value:

public DateTime CreatedAt { get; set; }
public Product()
{
    CreatedAt = DateTime.Now;
}

Tests that try to deserialize this will fail

Hooks for customizing serializer more easily

pass naming convention down into default serializer?

Silverlight Support

HttpClientHandler vs. HttpClient lifecycle

Ability to have multiple response handlers

    private Header Update(Model model)
    {
        var response = Client.Put(model, "models/:id", new { model.Id });

        response.On(HttpStatusCode.NotFound, () => { throw new Exception("Not found"); });
        response.On(HttpStatusCode.BadRequest, (List<ValidationError> errors) =>
        {
            throw new ValidationException(errors);
        });

        return response.On(HttpStatusCode.OK).As<Header>();
    }

When using On(Code, Action) don't throw exceptions if the status code does not match the expected status code.

Mono Support

Throw a meaningful exception when there are no serialiazers

This can happen if creating a client with the default settings... this should be clearer.

OAuth Support

Do a pass for dead code

Ensure all streams are disposed of properly

WindowsAuthenticator will no longer work in certain scenarios under .Net 5.0

Under the covers, HttpClient uses a new protocol, and in our testing, using Windows authentication will usually result in an Unauthorized error. See https://docs.microsoft.com/en-US/dotnet/core/run-time-config/networking

In .Net 3.x, you could work around this by forcing HttpClient to use the old stack, using:

AppContext.SetSwitch("System.Net.Http.UseSocketsHttpHandler", false);

However in .Net 5.0 this setting is no longer available. Instead, you'd need to use the https://www.nuget.org/packages/System.Net.Http.WinHttpHandler package and use that handler. Trouble is, this is a Windows-only thing, and adding this as a dependency in SpeakEasy will make it non-cross platform.

I thought of adding a DefaultClientHandler property to HttpClientSettings. Trouble is that all the IAuthenticator implementations use HttpClientSettings in their signatures, and we'd have change it to be HttpMessageHandler, which is a significant breaking change. Furthermore, the WindowsAuthenticator wouldn't work with that implementation either, given that the handler can either be a HttpClientHandler or a WinHttpHandler, both of which use different properties to set the credentials.

Conundrum.

Add default handlers

It should be possible to register a default handler, for example BadRequest which can unwrap and throw an exception.

Windows Authentication

Document middleware

WP7 Support

Road to 1.0 (part 2)

• Multipart mime content (content refactor)
• HttpClientHandler vs. HttpClient lifecycle
• HttpResponseState organization
• Make things internal where possible
• Do a pass for dead code
• All specs uncommented
• need a default text formatter
• #50 API for async calls
• Kill Header Abstraction?
• Make sure all streams are disposed of properly

Add internal modifier where possible

File Uploads

MonoTouch Support