jones139 / brewmap Goto Github PK

Could be
<p class="attribution"><a href="http://www.openstreetmap.org/copyright">&copy; OpenStreetMap Contributors</a></p>
to clarify tiles are cc-by-sa and data is odbl

The microbrewery icon looks a little too much like wine for my tastes.

Perhaps a beer glass would be better e.g. (if Unixy and Navit installed)::
/usr/share/navit/icons/beer.png

Which I think is from:
http://www.openclipart.org/
(website not very functional at time of writing)

Addition:
Maybe this would be good for distilleries:
http://www.dementia5.com/community/Themes/default/images/drinks/Whiskey.png
Although I can't determine the license on those images

Properties that are not defined for a given entity in the data set are being encoded into the JSON files as property=null. It would be better to just drop these, we have to test for existence in the JS client anyway.

The statistics box on the main map page should contain some statistics about the numbers of the various types of breweries etc.

I'm not sure landuse=vineyard is an appropriate tag to be tracking. It describes in general what a piece of land is being used for rather than indicating that a producer of wine is there. Additionally, the craft|industrial=winery tags is not being tracked.

An example is Stanlake Park near Twyford which is a winery [1] with attached vineyard [2]. Currently, just the vineyard is showing.

Another example of where this is a problem is the Denbies Wine Estate near Dorking which has 2 separate landuse areas ([3],[4]) both marked landuse=vineyard, which currently appear as two separate entities on the map. See issue #23 for my suggest of how to associate the 2.

[1] http://www.openstreetmap.org/browse/way/137952636
[2] http://www.openstreetmap.org/browse/way/137952641
[3] http://www.openstreetmap.org/browse/way/31864235
[4] http://www.openstreetmap.org/browse/way/31864240

I think the pop-ups should include the obvious boring stuff like the address and website.

The link to http://www.openstreetmap.org/browse/way/812411807, should be, http://www.openstreetmap.org/browse/node/812411807. I appreciate that particular feature is probably just an initial hack.

The link to browse the data in the pop-up provides basically the same functionality doesn't it?

Breweries tagged 'disused=yes' are plotted on the map - they should be ignored.

The brewery type is shown incorrectly in the popup, even thought the correct icon is displayed for they type of facility.

The data files use a made-up json format. We should use geoJSON (http://geojson.org/) for future compatibility with other software.
This is not a particular issue for the BrewMap, but if we use this code for other things that may need linear features or areas rather than just points, a geoJSON compatible format would be sensible. (I am thinking about the uk historic map, which will want to show roman roads etc as linear features.

We should make the code more abstract so that the same piece of code can be used for different maps with minimum changes. This will mean transferring more data, such as text for the web pages into the configuration file. You could then serve multiple maps from one directory by passing the name of the configuration file in the URL.

I find the web page layout doesn't use much of my display window.

Wouldn't it be better to set the sizes of stuff in brewmap.css as percentages rather than in fixed pixels.

The current approach of extracting all of the data into a single file is ok for the UK drinks industry, but will not scale well to either more dense points of interest, or a larger area.

The client should be able to request the features for a specific area as the map is panned and zoomed.

There are a few ways this could be done - will start to list them later.....

At low zoom levels the map is very cluttered with icons. If overlapping icons were clustered into a single icon it would be neater. I do not think that Leaflet supports this, so I think we would have to build a Leaflet plugin to do it.

In issue #22 I mention the Denbies Wine Estate near Dorking which has 2 separate landuse areas ([1],[2]) both marked landuse=vineyard, which currently appear as two separate entities on the map. The way to resolve this is using relations to associate the ways. I couldn't think of anything more appropriate, so I used a site relation [3].

[1] http://www.openstreetmap.org/browse/way/31864235
[2] http://www.openstreetmap.org/browse/way/31864240
[3] http://www.openstreetmap.org/browse/relation/1858412

If some twigglet has tagged something as microbrewery=no, then there is a false positive (http://www.openstreetmap.org/browse/way/80580032).

The proposed tagging scheme has changed to be 'industrial=brewery'. Breweries tagged like this are appearing in the tagQueries page rather than on the map.
This is a trivial change to the server code to change the column that is queried, but needs a database import to add the 'industrial' column to the database - job for the weekend of 19 November.

The client code now uses BrewMapCfg.json to define what to plot on the map and which icons to use.
The server side code needs updating to read the same configuration file.

Dunkertons near Pembridge makes both cider and perry, so I've tagged it with industrial=cider;perry. It isn't appearing.

http://www.openstreetmap.org/browse/way/137818693

The map key should be generated automatically from the configuration file BrewMapCfg.json

Add a layer selector so you can switch off (say) microbreweries etc. Probably means re-cycling right hand pane, so will make right hand pane a tab selectable pane for the key, statistics or layer switcher.

It might be useful to see the tagQueries displayed on a map (like the main features) as a selectable layer to help people look for issues in the areas they know about.
Probably implement with a GET parameter (....brewmap.html?tagQueries=yes)?