jonahsnider / convert Goto Github PK

This is not an issue but a feature request to add units of speed to convert. Data sizes (e.g 1tb to kb) would be another great addition. Thanks for all the good work on this so far.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (@pizzafox)

please double check square because these are not working correctly

square kilometers
square centimeters
square millimeters
square micrometers

convert(2000, 'ft').to('meters') returns 609.6 which is correct
but
convert(609.6, 'meter').to('ft') returns 1999.9999999999998 which should be 2000 ft and is incorrect ?

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨

Your semantic-release bot 📦🚀

I have tried to install and trying to import but it is giving me error like ' Could not find module convert imported from'. Though I am able to see this in node_modules. Please suggest me how to procceed.

Version used: 5.0.0

Hi, there seems to be a floating point problem when converting from 1 foot into inches.

convert(1, 'ft').to('in')  // Results in 12.000000000000002

I know there can be floating point problems in javascript, but I would expect this basic conversion to work properly.

Thanks!
Raymond

Hey!

The "µ" char in this library has the char code 956 (unicode). Our backend responses with a unit string "µm" where the "µ" has the char code 181 (ASCII).

The library can't handle this char and throws an RangeError.

Looking through the docs I dont see any conversion types for speed. I often work in inches per second, but threejs uses meters so I have to convert. Would be great to get this built in or the ability to define custom units. If possible, I think a generic solution for this would be best where you can use any already defined length unit over any defined time unit instead of adding in specifically in/s, m/s, miles/h, etc...

With this, the dividend I guess could also be an angle... degrees/s, radians/m, etc.

I'm using two different conversion utilities. meters to feet conversion isn't matching. I realized the ratio used here is rounded and not right.

{ names: ['foot', 'feet'], symbols: ['ft', "'"], ratio: 0.3048 },

1 m = 3.28084 ft
or
1 ft = 0.3047999902464003 m

Issue: Duplicated code and Failure to expand tonnes in mass.ts

Description:
There is a duplication of code in the mass.ts file, specifically in the conversions array. The expandMacro method is called twice with the same parameters, resulting in the duplication of conversions and a potential oversight. Additionally, this duplication prevents the proper expansion of units for ton (tonne) measurements.

Steps to Reproduce:

1. Go to the mass.ts file.
2. Locate the conversions array.
3. Notice that the expandMacro method is called twice with the same parameters.

Expected Behavior:
The expandMacro method should be called only once with the appropriate parameters to avoid duplicated conversions. Furthermore, the expansion of units for ton (tonne) measurements should be included.

Actual Behavior:
The expandMacro method is called twice with the same parameters, leading to duplicate conversions. As a result, the expansion of units for ton (tonne) measurements is not present in the conversions.

Code Snippet:

const poundInGrams = new BigNumber(4.535_923_7e2);

export const mass: ReadonlyDeep<Family> = {
	// ...
	conversions: [
		{names: ['gram', 'grams'], symbols: ['g'], ratio: 1},
		...expandMacro(Macros.si, {names: ['gram', 'grams'], symbols: ['g'], ratio: 1}),

		{names: ['tonne', 'tonnes', 'metric ton', 'metric tons'], symbols: ['t'], ratio: 1e6},
		...expandMacro(Macros.si, {names: ['gram', 'grams'], symbols: ['g'], ratio: 1}),

		// ... other conversions ...
	],
};

Proposed Solution:
Remove the duplicated expandMacro method call at line 20, as it duplicates the conversions already added at line 17. Additionally, modify the second expandMacro call to properly expand the units for ton (tonne) measurements.

Replace method call at line 20

...expandMacro(Macros.si, {names: ['gram', 'grams'], symbols: ['g'], ratio: 1}),

with

...expandMacro(Macros.si, {names: ['tonne', 'tonnes', 'metric ton', 'metric tons'], symbols: ['t'], ratio: 1e6}),

d.ts files cannot define types for .mjs files

First off want to say love this package. Very clean and easy to use.

Feature request:
Thoughts on adding pixels and points to the length type?

It seems that there are no energy units included (joule, kcal, watt, kWhm btu, etc.), I think it would be a great addition.

Affecting version: v4.6.1

TypeError: (0 , convert_1.default) is not a function

      2 | describe('test convert package', () => {
      3 |   it('Project example', () => {
    > 4 |     const result = convert(1, 'miles').to('km');
        |                           ^
      5 |     expect(result).toEqual(1.609344);
      6 |   });
      7 | });

Reproduce repo:
https://github.com/ls-jingbo-jin/convert

is it possible to add converstion measure for light year to measure? e.g.

convert(1, "light year").to("kilometer")

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Cannot push to the Git repository.

semantic-release cannot push the version tag to the branch master on the remote Git repository with URL http://x-access-token:[secure]@github.com/jonahsnider/convert.git.

This can be caused by:

• a misconfiguration of the repositoryUrl option
• the repository being unavailable
• or missing push permission for the user configured via the Git credentials on your CI environment

Good luck with your project ✨

Your semantic-release bot 📦🚀

to continue, in this case if we convert 3 Grams to Petagrams we get 3.0000000000000002e-15 and rounding this number leads to errors

          This issue still persists as of v4.13.2. It shows "Uncaught TypeError: convert is not a function" error

Originally posted by @mahony0 in #560 (comment)

Moving discussion here, as the bug you are describing is not the one in the issue originally commented in

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two Factor Authentication for your account, set its level to "Authorization only" in your account settings. semantic-release cannot publish with the default "
Authorization and writes" level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨

Your semantic-release bot 📦🚀

convert(1, 'US legal cup').to('cup')

should return 1.01442 but instead it's 1

By trying other conversions is US legal cup that does not convert any measure properly, it converts them as a normal cup, so that's the data that needs correction.

As described in the title.

Hiya,

I'm trying to convert from squared millimetres (mm2) to squared meters (m2) or 'best' since the values can get quite large.
I'm not finding any options for squared values with intellisense in vscode, but i do see some cubic (m3) conversions.

Am i blind or can someone point me in the right direction?

Heyyya, thanks for creating this library!

It looks like it repeats the well-known Javascript precision error with 0.1 + 0.2 !== 0.3.

Repro:
https://codepen.io/goodwin64/pen/vYPrMRW?editors=1010

Looking through the pressure conversions available I do not see one for psi, would it be possible to add it?
{names: ['psi'], symbols:['psi'], ratio: new BigNumber(6_894_75729).div(1e5)},
Would be all that was required, no?

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Cannot push to the Git repository.

semantic-release cannot push the version tag to the branch master on the remote Git repository with URL http://x-access-token:[secure]@github.com/jonahsnider/convert.git.

This can be caused by:

• a misconfiguration of the repositoryUrl option
• the repository being unavailable
• or missing push permission for the user configured via the Git credentials on your CI environment

Good luck with your project ✨

Your semantic-release bot 📦🚀

Would it be possible to make the function return null or false when a conversion fails?

For example calling:

convert(360, 'sec').to('min')

will output the whole library code.

Would be nice in it's place to get a falsy value to evaluate against.

All data conversions fail if using bigint due to Conversion for [UNIT] to [UNIT] cannot be calculated as a BigInt because the conversion ratio is not an integer error. 
Even a simple operation like this fails:

convert(1024n, 'B').to('KiB');

When doing conversions with US dry quart and US dry pint to litres the values are incorrect (i.e. convert(1, 'US dry quart').to('l'))

The correct ratio values for dry measures are listed here (https://en.wikipedia.org/wiki/United_States_customary_units#Dry_volume and https://en.wikipedia.org/wiki/Dry_measure#US_units_of_dry_measure) as mentioned in the comments in src/dev/conversions/volume.ts.

Expected behaviour:
1 US dry quart = 1.101221 L
1 US dry pint = 0.550610 L

Actual behaviour:
1 US dry quart = 0.946352946 L
1 US dry pint = 33600.3125 L

Hi. I found your package today and it's excellent. Thanks so much for putting it together.

One thing I'm always having to do is rounding for display purposes. I'm curious if you'd be interested in adding round and/or toFixed with decimal places to your package.

My thinking is that everyone doing these conversions needs to also round for display purposes.

About 6 months ago I tested many solutions and settled on this for speed and accuracy.

// Modified version of Solution #2 from https://stackoverflow.com/a/48764436/25197.
// Fast and accurate.
const DecimalMath = (() => {
  const decimalAdjust = (type, num, decimalPlaces) => {
    const precision = 10 ** decimalPlaces;
    const n = num * precision * (1 + Number.EPSILON);
    return Math[type](n) / precision;
  };

  return {
    round(num: number, decimalPlaces = 0) {
      return decimalAdjust('round', num, decimalPlaces);
    },

    // Format using fixed-point notation.
    toFixed(num: number, decimalPlaces = 0) {
      return decimalAdjust('round', num, decimalPlaces).toFixed(decimalPlaces);
    },

    ceil(num: number, decimalPlaces = 0) {
      return decimalAdjust('ceil', num, decimalPlaces);
    },

    floor(num: number, decimalPlaces = 0) {
      return decimalAdjust('floor', num, decimalPlaces);
    },

    trunc(num: number, decimalPlaces = 0) {
      return decimalAdjust('trunc', num, decimalPlaces);
    },
  };
})();

export default DecimalMath;

To see the round and toFixed functions in action click the Run Code Snippet button on this stackoverflow answer. There are 30 answers on that page and I went through the comments in each one to find the places where each answer broke and made sure my version worked correctly.

I imagine a version of convert that can do this.

convert(150).from('pound').to('kilogram').round(2)

If any of this seems reasonable and you want me to take a stab at a PR I can do that as well.

Feature request: Ability to define custom units
If this is already possible, some documentation on how to do so would be super.

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

No npm token specified.

An npm token must be created and set in the NPM_TOKEN environment variable on your CI environment.

Please make sure to create an npm token and to set it in the NPM_TOKEN environment variable on your CI environment. The token must allow to publish to the registry https://registry.npmjs.org/.

Good luck with your project ✨

Your semantic-release bot 📦🚀

Hi, I couldn't find any information about doing a round operation automatically or even triggering it with some param.

So while the examples in readme seems to be accurate, the example of convert(1930536, 'meters').to('best').toString() returns me an ugly result of 1930.5359999999998km. I expected to maybe get 1930.54km as a result when using a "best" param.

Converting from F to C results in incorrect value.

const tempC = convert(68.0, "fahrenheit").to("celsius");

the output is: 5.777777777777779 while it should be 20

Converting from C to F works as expected and K to C does, too.

When using the "best" parameter for data conversion it always returns the binary unit (KiB, MiB, etc.) for both the "imperial" or "metric" parameter. I think when using the "metric" param, it should be returning MB, GB, etc.

This seems to be a simple change in your bestUnits type for the "metric" kind, was hoping this could be updated.

Thanks!

convert(1000).from('ml').to('l') , I am expecting output as 1.

Is there any support for BTU? sorry if this is the wrong channel.

International feet (ft) is supported but it would be useful to have U.S feet too

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Pending Branch Automerge

These updates await pending status checks before automerging. Click on a checkbox to abort the branch automerge, and create a PR instead.

• build(deps): update vitest monorepo to v1.6.0 (@vitest/coverage-v8, @vitest/ui, vitest)

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• build(deps): update dependency @microsoft/api-extractor to v7.44.0

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

I tried the unpkg link for this repo and it did not work. I hacked the script to extract the convert, convertMany, and ms functions out (if you're looking to do this just set e to an external variable where e.convert is being set.)

Maybe I did something wrong but I had to hack it to extract the convert function at all. It doesn't set on the window.

Basic meters to feet conversion is correct, but cubic length conversion deviates by about 0.2 from the correct conversion value.

Add Kb and KB to data digital units.

Is there a way to use m for minutes with the ms shorthand utility? I see m is used for meters currently but its also commonly used for minutes. (even in the ms package)

Hello, a problem with rounding by all measures was found.
for example, if we take 10 square meters and translate them into square kilometers, we get 0.000009999999999999999, while if we take 11 we get the correct answer 0.000011, and so on for all metrics

Thanks for your consideration...

Currently

convert(16, 'tablespoon').to('best')

results in 236.5882365 mL, which is accurate but perhaps not the best option as 16 tablespoons = 1 cup.

It would great if the best option could be restricted to the measurement system of the input.

Or perhaps I have missed how to do that today?

(convert(1400, "kg").to("t")
出现1.4000000000000001