joke / spock-outputcapture Goto Github PK

Hi @joke , we discovered that CapturedOutputImpl.getLines() results in a String-list with one (empty) element if nothing has been logged yet. We would have expected a zero-element list here (empty log = zero lines logged).

We would love if you added a special treatment for the case that nothing has been logged yet:

@Override
    List<String> getLines() {
        if (buffer.length() == 0) return []
        return asList(buffer.toString().split("(\\r\\n|\\n|\\r)"));
    }

Describe the bug

Using this library from maven central is not possible with java 11. It needs at least java 14.

To Reproduce

0. Use version of lib from maven central, for example as dependency in pom.xml
1. Add @OutputCapture foo to you test
2. Run the test
3. You get:

   Caused by: java.lang.UnsupportedClassVersionError: io/github/joke/spockoutputcapture/OutputCapture has been compiled by a more recent version of the Java Runtime (class file version 58.0), this version of the Java Runtime only recognizes class file versions up to 55.0
   

Additional context

The configuration for that is in build.yml:25