FRUS1949v05 about frus-tei

[vak2ve]

Abbreviations and terms not rendering in side box though look fine in XML. @joewiz help?

[vak2ve]

Possible typo in print version at top of p. 249--doesn't seem to follow from text of 248.

[joewiz]

@vak2ve The issue is that the <term> and <hi> elements are appearing in essentially reverse order. In FRUS persons and terms list, the trailing comma that marks the end of the person/term being described is also bold.

The correct way to capture this is (adding extra indenting for clarity here):

<item>
    <hi rend="strong">
        <term xml:id="t_ACR1">ACR</term>, 
    </hi> 
    Advisory Committee on Requirements
</item>

Instead, in this volume, the placement of hi is inside the term, as follows:

<item>
    <term xml:id="t_ACR1">
        <hi rend="strong">ACR</hi>,
    </term> 
    Advisory Committee on Requirements
</item>

Since our site assumes the former structure, it mangles the display of the latter. We should probably return these volumes to HCL to correct. Could you please assemble the list of affected volumes? This is probably also an opportunity for a schematron rule to check for this problem. Good catch, thanks!

[vak2ve]

This was a huge global error--see most recent commit for all files affected. They're fine now (relatively quick fix) but definitely something to communicate to HCL for the future.

[joewiz]

Is this one all set now, or are there any remaining issues?

[vak2ve]

Yes, this and Malta should be good to go now!

On Wed, Apr 8, 2015 at 3:29 PM, Joe Wicentowski [email protected]
wrote:

Is this one all set now, or are there any remaining issues?

—
Reply to this email directly or view it on GitHub
#29 (comment).

[joewiz]

Okay, I assume that one remaining checkbox is actually done, so I'll go ahead and close the issue. Thanks!