Coder Social home page Coder Social logo

Review frus1917-72PubDip about frus-tei HOT 5 CLOSED

seckroth avatar seckroth commented on July 28, 2024
Review frus1917-72PubDip

from frus-tei.

Comments (5)

seckroth avatar seckroth commented on July 28, 2024

For DSCS:

  • missing source note coding
  • missing abbreviation and person-list ref/@target and persName/@corresp tags in documents
  • missing <pb/> tags
  • cross-references not tagged

from frus-tei.

seckroth avatar seckroth commented on July 28, 2024

d#6, 13, 27, 33, 35, 36, 37, 41

  • signature incorrectly formatted. (<affiliation> is inside the <signed> portion of closer) and no <lb/> in signature

waiting on Preface to fully review front matter

from frus-tei.

joewiz avatar joewiz commented on July 28, 2024

I uploaded the latest to SVN and fixed schema issues in this version:

  • Wrong volume ID in the <idno> header element
  • Each section of the appendix needs its own <div type="section" xml:id="appendix-1"> (and 2 and so on); schema complained of head elements missing div elements

I also fixed this issue that DSCS should have caught:

  • Need to remove .tif file extension from graphics, since web vs. print outputs use different image formats

I added the embedded video code to Appendix 5 and 11, and uploaded some sample images to S3 so the "still clip" that shows above the videos would display.

DSCS still needs to address these issues:

  • Need to supply @type="source", still missing on all source notes
  • Need to properly code left & right alignment on the same line as documented at #12 (and as instructed in June email re: #d13)
  • Need to convert character entities (search for &# for all 4 instances) to actual Unicode characters
  • Need to tag cross references to documents in Appendix source notes

from frus-tei.

joewiz avatar joewiz commented on July 28, 2024
  • Also, need to tag cross references to Appendices in the body documents

from frus-tei.

joewiz avatar joewiz commented on July 28, 2024

This issue was moved to HistoryAtState/frus#16

from frus-tei.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.