joelsmith123 / byob Goto Github PK

DELETE responses don't need a message, just the status codes, the messages can be deleted.

202 error code means the request has been accepted but not processed. It's not applicable for our DELETE methods.

204 error code means the requested item has been successfully deleted and is applicable for DELETE methods.

Instead of sending messages with send, sending the message as an HTML element, we want to consistently send our response messages as json data.

Bad example:
https://github.com/JoelSmith123/byob/blob/master/server.js#L125

Good example:
https://github.com/JoelSmith123/byob/blob/master/server.js#L227

Currently in the DELETE methods, the existance of the request ID is verified after deletion has already occured. Example:

  database('restaurants').where('id', request.params.id).del()
  .then(restaurantId => {
    if (restaurantId) {
      response.status(200).json({ id: request.params.id })
    } else {
      response.status(404).send('No restaurant with that ID currently exists')
    }
  })
  .catch(error => {
    response.status(500).json({ error })
  })
}) ```

Change so verification occurs before deletion of object by ID.