joelonsql / wherr Goto Github PK

Being able to work with the anyhow crate would make this crate much more ergonomic for use in existing code. Currently, wherr uses Box<dyn Error> as it's inner error type and error returned from wherrapper. This is not Sized, Send, or Sync, meaning it cannot be converted into anyhow's Error type. Based on some testing I've done locally, the API of anyhow::Error is similar enough to that of Box that there would be nearly no code changes necessary between the two implementations.

I'd like to propose the existence of a feature flag which would switch wherr to use anyhow::Error as its inner error type. This could either change the behavior of the #[wherr] macro directly, or enable the existence of a #[wherr_anyhow] macro, whichever seems most convenient (though I lean toward the former).

If this is something you're interested in, I'd be happy to submit a PR implementing these changes.

Hi Joel,

I like wherr and would like to use it in our project. We are converting a C# project to rust. And one feature that we miss in rust is callstack for exception, which helps us to locate the issue. So I try to add something similar in this PR. Can you help review it?

#3

Thanks,
Kai

If some users include your library with Anyhow, and some without it, a project including both such libraries will not build. You need to change your design so that the feature is additive, that is adding anyhow shouldn't break code which relies on using std::error::Error