joanb / chessclockswift Goto Github PK

I think it would be nice to remove this large Pods/ directory from the repository.
If we do it, then we need to remove .xcworkspace file too. if so, then anyone who wants to clone this repo should then run pod install. Cocoapods will install all necessary pods and generate .xcworkspace.

When paused, give the chance to resume the clocks.
If the game was paused when whites were playing, it should be resumed as whites turn, and the same applies for blacks.

This button will be added without behavior in #9

Currently, both clocks are disabled when pause button is clicked, but only one is clickable (the one who was ticking when the pause was pressed).
This is a UX problem that may confuse the user.

The current ticking clock should stay in active status (AKA no alpha applied) when pause button is pressed.

Instead of having a big viewmodel with all the parameters of the view, it would be nice to render States (this could be a enum) with the params needed for that state only.

Posible States (debatable):

• WhitesRunning
• BlacksRunning
• Paused
• Stopped

Hi, just out of curiosity. Is there any particular reason why we use RxSwift but we're not using RxCocoa in the viewcontroller? :)

Expected behavior:
The Reset Button is initially hidden.
When the game is paused, the Pause button is hidden and two new buttons are shown:

• Resume
• Reset

Logic for these buttons will be addressed in other issues.

The idea is to remove the top and bottom buttons (not only they are unnecessary, but the top player see the button upside down).
The click behaviour should be implemented by the clocks (click on one clock to change the turn)

The observable.merge is not merging any observables right now, so it can be removed from ClocksPresenter.
The interval observable is needed, it's enough to delete the Observable.merge line and its respective closing parenthesis

The pause button should be shown as disabled when it's pressed