jjhuang / betterworks-demo Goto Github PK

scope.$watchGroup will perform better
also, when watches are triggered, newValue and oldValue are guaranteed to be !== or else the watch function wouldn't be running

seems to be hardcoded at 150x150
ideally, it would expand based on the element's width

tests should make sure that the arcs end up being drawn somewhat correctly

noticed that you have color hex codes in the controller js file, designers will want to be able to tweak css without touching js files

noticed that you use 1e-6 for some reason, better to move it into a constant and comment on why its necessary

please dont mix and match single with double quote in controller
also, many of your key values don't have to be strings

{id: 1, expected: 0.5, actual: 0.25} 
// vs
{'id': 1, 'expected': 0.5, 'actual': 0.25}