jhsheets / javafx-filterable-table-columns Goto Github PK

Columns of type string present the various operators (contains, equals, etc.). I would like to delete them in order to manage only the contains side query. Is there any way?

Thanks

Filtered column count: 1
Filtering changed on column: Value
Current filters on column Value are:
Type=Contains, Value=Ba

Result: no rows are hidden!

In FilteredTableView.java inside overridden onChanged method, when columns are removed from a FilteredTableView, the FILTERED_CHANGE_EVENT listeners are being removed from the wrong set of columns.

On line 106, shouldn't it be change.getRemoved() instead of change.getAddedSubList()

Simple test...
Create a column that contains all other columns: idColumn, valColumn, typeColumn, dateColumn, boolColumn

Execute and see the result. Nothing happens!

Hi I'm not sure if this codebase is being maintained but I wanted to point out an issue in case you or any user of the code base wanted to know.

When using FilterableEnumTableColumn with arguments selectByDefault=true it leads to issues where the filters are not present in FilterableEnumTableColumn "filterResults" field, accessed via getFilters() when applying filters. These filters would also normally be set after a save request on the editor, but when selectByDefault=true is set it doesn't seem to update anyway because of an mistake or design flaw on line 215 of EnumFilterEditor.java, see below:
if (emu.isSelected() != selectedByDefault)
This check seems to be of the intention of seeing if it has changed since default, but it can't distinguish between whether it is unchanged or just not been changed back to default.

I think these solutions can be resolved by doing the following simple changes:

1. When constructing an AbstractFilterableTableColumn with selectByDefault=true, immediately set filterResults, also theres a bug on the third constructor where selectByDefault isn't passed on to the fourth constructor.
2. Further to above, when setting new options with setEnumValues(T[] values), you will also need to update the filterResults field to match the new options.
3. Remove the check comparing isSelected to selectedByDefault and just treat all selected checkboxes the same regardless of default.

In a modular JavaFX project, it is not possible to use this very useful project.

Caused by: java.lang.IllegalAccessError: class org.google.jhsheets.filtered.tablecolumn.editor.FilterMenuPopup (in module javafx.filterable.table.columns) cannot access class com.sun.javafx.css.StyleManager (in module javafx.graphics) because module javafx.graphics does not export com.sun.javafx.css to module javafx.filterable.table.columns

AdoptOpenJDK 12
JavaFX 12