jhontolentino / ecommerce-pattern-library Goto Github PK

My site for sure has issues on certain accessibility components and with a little bit of elbow grease it can be fixed up. There are some issues on responsiveness but, I haven’t found anything ground breaking. I am for sure not looking for an amazing mark to boost my grade since I honestly do not feel I deserve that leniency. All I am asking for from this grade is that I do not fail and I can continue on to next semester’s Web class.

Style & design — 2

I feel like the styles and design match well to show a more lighthearted attempt at a magic store. The bright colours help portray a more welcoming store rather than having a more serious, darker undertone.

Patterns — 2

I have a decent variety of old patterns and new ones mixed in to create a more dev friendly reproduction.

Explanations — 2

I feel like the explanations are helpful but, that is due to the fact that I wrote the code myself

Accessibility — 1

Certain places on webpages have accessibility issues especially with legibility issues

Sementics — 2

Most of the html is a good variety of grids, styles and sizing due to the fact that most of the colour were already chosen in Theme.css

Responsiveness — 2

Works on all screens but there is definitely some awkwardness when screens are resizing.

Code Quality — 2

Most of the code is quite easy to get to change if need be an easily found.

Git & commits — 1

I could’ve had much better messaging if I had committed after every huge change/creation.

14/24 — 58%