prj-rev-bwfs-dasmoto's People
prj-rev-bwfs-dasmoto's Issues
(Extra) Great idea!
You're really going above and beyond by adding this alt-text, I think that's the first time I've seen that in a submission!
(Durability) It can be easy and wise to add a backup here
In the unfortunate case that your user has a browser which doesn't support your font of choice, a simple ", sans-serif;" here can prevent an adverse outcome.
(Summary) Nice work!
You've got clean, readable documents which are delivered to-spec - way to go! I see you doing some particularly nice things like adding alt-text. Where you go above and beyond the spec, I see some cases where you make your document more specific or robust, others where you make it less robust or more general. See the individual issues for examples.
Given that observation, I think that in terms of improvement you can spend more time thinking about how your document might break. Looking over your submission I kept coming back to brevity, specificity and durability. With a simpler project like this it's certainly less of a concern, but good habits will enable you to tackle more complex tasks.
(Specificity) Wildcard may be too broad here
We want to be very selective about where we use the wildcard symbol - it probably would suffice to name: h1, h2, h3, p
(File management) css and html files in same directory
In your repo and your filepath strings you have your css and HTML docs in the same directory. There's nothing technically wrong with that, but it's good to be in the habit of storing css docs as a resource (in an src or resources folder)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.