jhfullen / prj-rev-bwfs-dasmoto Goto Github PK

You're really going above and beyond by adding this alt-text, I think that's the first time I've seen that in a submission!

In the unfortunate case that your user has a browser which doesn't support your font of choice, a simple ", sans-serif;" here can prevent an adverse outcome.

You've got clean, readable documents which are delivered to-spec - way to go! I see you doing some particularly nice things like adding alt-text. Where you go above and beyond the spec, I see some cases where you make your document more specific or robust, others where you make it less robust or more general. See the individual issues for examples.

Given that observation, I think that in terms of improvement you can spend more time thinking about how your document might break. Looking over your submission I kept coming back to brevity, specificity and durability. With a simpler project like this it's certainly less of a concern, but good habits will enable you to tackle more complex tasks.

We want to be very selective about where we use the wildcard symbol - it probably would suffice to name: h1, h2, h3, p

In your repo and your filepath strings you have your css and HTML docs in the same directory. There's nothing technically wrong with that, but it's good to be in the habit of storing css docs as a resource (in an src or resources folder)