Coder Social home page Coder Social logo

Comments (3)

jhermsmeier avatar jhermsmeier commented on June 19, 2024

Well, issue #33 has been around since v1.0.0 judging by git blame, and since LF delimited VCF is technically malformed, I'm not sure what you'd like to change?

from node-vcf.

rbeeger avatar rbeeger commented on June 19, 2024

It's totally fine that 2.0.6 fixes the output to be wellformed, but it should still be able to parse output generated by an earlier version even if it is now considered to be malformed.

And it's a patch level update. Patch updates shouldn't break that kind of thing.

from node-vcf.

jhermsmeier avatar jhermsmeier commented on June 19, 2024

And it's a patch level update. Patch updates shouldn't break that kind of thing.

Patches fix bugs. This was a bug, not an API change. Sorry it broke something, but that broken something is likely broken for most other things that parse VCF as well.
I agree that this is very unfortunate breakage, but given that the bug has been around for that long and nobody had complained about it, I figured patch level would be fine.

but it should still be able to parse output generated by an earlier version even if it is now considered to be malformed.

The issue with that is that it would break multi-line fields (i.e. some quoted-printable encoded data, see #31 for an example) or other line-folded values. If you know that you don't have line-folded values in your vCards, you could treat them with .replace( /\n/g, '\r\n' ) before parsing though.

from node-vcf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.