Coder Social home page Coder Social logo

Comments (4)

jhalterman avatar jhalterman commented on July 17, 2024

I wouldn't make retries for this exception part of the default behavior, but I've thought about adding the ability to configure which Exception types should be retryable/recoverable, and I think this fits in well with that idea. I'll try to get that in this morning...

from lyra.

jhalterman avatar jhalterman commented on July 17, 2024

@stettix Let me know what you think of the change I committed...

config.getRecoverableExceptions().add(PossibleAuthenticationFailureException.class);

from lyra.

stettix avatar stettix commented on July 17, 2024

Wow, that was a quick response, thanks!

The change looks very good to me. I had a quick go at doing this myself but your change is more general, hence much better.

And I definitely wouldn't suggest changing the default behaviour, just making it optionally configurable is great.

from lyra.

jhalterman avatar jhalterman commented on July 17, 2024

Pushed a new release with this, 0.4.3. Should be sync'ed to maven central in an hour or so.

from lyra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.