Comments (8)
The point of client-provided names was never to make it easier to load in the apps, although there's nothing wrong with that. The point is to make it visible in server logs (when a connection is accepted) and management UI (for the entire lifetime of a connection).
from lyra.
I'm not sure if I understand. I need it for logging :-) But anyway, the reason is IMO not relevant - is there a problem with passing it there from Lyra? AFAIK it's the same value as I would havewhen creating the connection by myself, except I don't any Lyra stops me from passing it there (well I found a way how to override it, but...).
from lyra.
@jendakol Happy to take a PR for this.
from lyra.
@jhalterman I would do the PR directly, but it's one-line change and it will take more time to me to fork the repository etc. than you to fix it, but if you insist.. ;-)
from lyra.
@jendakol asking the maintainer to do stuff is not how open source works, ya know.
from lyra.
@michaelklishin I agree in general but thought this case could be the exception. I as a maintainer wouldn't be offended if someone tell me "hey, you have a bug here, fix it with this", if it would be that simple as this is.
from lyra.
@jendakol You're not wrong, but at the same time for someone who works on lots of projects and doesn't have a lot of free time, getting a pull request is always a nice thing :) Ideally, a project should make it as easy as possible to fork/clone/build/test a change so that one line fixes are quick for anyone to do.
from lyra.
from lyra.
Related Issues (20)
- Reconnection after RabbitMQ shutdown is not successful HOT 5
- when java.net.UnknownHostException is thrown the recovery failed
- What about moving to the latest 'amqp-client' version?
- Forgotten copying of automaticRecovery in ConnectionOptions.copy() HOT 1
- Documentation on ConnectionFactory used in ConnectionOptions HOT 2
- support withUri() in ConnectionOptions HOT 5
- Moving to latest RabbitMQ Java Client 4.0 HOT 5
- Why to copy ConnectionFactory on each create HOT 7
- No communication after recovery HOT 4
- Consumers not getting messages after broker restart HOT 8
- RabbitMQ flooded by new connections HOT 5
- Lyra recover mechanism can prevent from the JVM to shutdown HOT 6
- Get rid of static executor service HOT 2
- Rapid growth of connections when network conditions are unreliable HOT 3
- retryableExceptions configuration and implementation HOT 3
- Use a `Predicate` for retry exception strategy
- Getting Rabbitmq HeartBeat Exception HOT 3
- Lyra is no longer under active development. HOT 1
- Connection recovery fails and gives up even though recovery policy is recoverAlways() HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lyra.