jgthms / web-design-in-4-minutes

Learn the basics of web design in 4 minutes

Web design in 4 minutes

Learn the basics of web design in 4 minutes!

web-design-in-4-minutes's Issues

AWESOME!! I want to translate in Korean

I'm so impressive with your page.
May I translate in Korean?
It's so GREAT ever I have been seen it.

Chinese translation

Awesome.
May I translate to Chinese?

How do the sections just appear without JS?

Am I missing something? How is it that the sections just appear when you click the links?

http://jgthms.com/web-design-in-4-minutes/

Thank you

Thank you @jgthms

Book

Awesome! A few suggestions using new CSS features

First, thanks a lot for your eye-opening, dead simple content!

I'd suggest some minor improvements to take advantage of new CSS features:

1. in "Centering" body width limit can now be set semantically: (seen recommended 60-75ch https://piccalil.li/quick-tip/line-length/)

body {
  max-width: 60ch;
}

2. in "Balance" monospaced inline items can also use better units:

code,
kbd,
samp {
  padding-inline: .3ch;
}

• I found the vertical-align: text-bottom; to render very strangely, are you sure about this one?

Thanks again!

Your text contrast advice ruins legibility and fails ACAG

Making text #666 on white fails ACAG AAA. (contrast ratio 5.7)
Making text #666 on #eee does too (contrast ratio 4.9)
Making code text #a7adba on #f5f7f9 fails WCAG 2.0 entirely (contest ratio 2.1)

Sabotaging contrast like this does not help readers at all.

Open source licensing

Is this project open source? if so, what's license for it?

Spanish translation

Great project!
Would you like a spanish translation?

You are awesome!

The site is not working properly

See the picture
https://i.imgur.com/npoe2BW.png

Web

Hash router does not support the browser's back button

Hash router does not support the browser's back button