jgthms / minireset.css Goto Github PK

Hey,

can you please make the package available via bower! That would be very awesome, thank you.

This reset feels like it's definitely missing font-family: inherit on things like form fields.

Hey @jgthms, I hope you’re well.

I’m just wondering what the decisioning was for

ul {
  list-style: none;
}

But omitting ol from list-style: none?

Thanks.

I'm using a simple rule:

td
  text-align: center

since the rule in the minireset is more specific, it take precedence over mine.

I can easily solve this by modifing the minireset, but then what is the idea of using the minireset. I could use my own version, but the truth is that I dont even know what does the line that I removed.

This is an issue and a question...

What &:not([align]) does? I couldn't find anything on the web (I mean like, what exactly does?)

Copying code from Bulma: https://github.com/jgthms/bulma/blob/master/css/bulma.css#L312. Shouldn't minireset.css include a precaution for HTML5 elements for older browsers?

article,
aside,
figure,
footer,
header,
hgroup,
section {
  display: block;
}

Seems like it should be the second rule, beneath

... {
  margin: 0;
  padding: 0;
}

Hey @jgthms !
First, congrats for the project. Great idea.

About the media's content: how about adding iframe in the responsive declaration?

Something like that:

img,
embed,
object,
audio,
video,
iframe {
  height: auto;
  max-width: 100%;
}

So I wanted to suggest this because as it turns out, some browsers don't set the body's background to #FFFFFF or its colour to #000000 by default, this can happen on some browser themes or if the user set their own colours.

And this breaks many many websites, but many people who use settings and themes like that blame it on the devs of the website.

Since not a lot of devs are aware of this and yet most people would want to have a reliable background and text colour, maybe it would be a good idea to add

:root {
    background: #FFF;
    color: #000;
}

Since :root has the lowest CSS priority, it should not break anything, most people apply the background on html or body anyway.

I don't wanna debate on if those people are right or wrong to change their default background and text colour, there is also no actual HTML or CSS standards saying browsers should set the background to a certain colour as far as I'm aware, so it's not like they're 100% wrong.

I am not sure if this is in the minimalistic scope of your project, I do feel like it is because it is a very elemental reset that you could argue would help many websites out there. And that, if more people were aware of this, everyone would start their project by resetting the background and text colour.

Hey,

how about adding this, to avoid the unwanted, very weird space below images. Or is this issue already covered with something else?

img{
    display: block; /* avoids space at bottom */
}

Lines 15 and 46 in minireset.css set textarea { margin: 0; } both.

Am I an idiot? I'm having trouble linking this like this:

<link rel="stylesheet" href="https://raw.githubusercontent.com/jgthms/minireset.css/master/minireset.css">

But works when I download and import locally. 🙉

Instead .sass try to write .scss, can be more useful.

And maybe better some mixins like "@include box-sizing(border-box);"

add @charset "UTF-8"; ?

Hello,
It could be great if this library can be loaded using bower

What do you think ?

Hi guys,

A letter is missing ;)
minireset.sass instead of minireet.sass

✌️

That's not a real issue, but what about keeping the reset really modern by using start aka logical props:

*:before, *:after {box-sizing: inherit;} is causing some weird behaviour in MacOS Safari's webinspector:

For some reason I can't explain when inspecting the DOM in Safari :before and :after elements keep appearing and disappearing all the time without doing anything.

On page-filling, no-overflow webpages this leaves a permanent scrollbar on the screen.

Not 100% sure it's an issue but when I upgraded Bulma some of the social iframe buttons had too big of an height. See screenshot. If the height: auto is toggled off the Github button returned to its normal height.

Link: https://swiss-element.netlify.com/