Comments (17)
Actually, I realized I am getting a console error from that example at the moment when the characters reach 10:
patch.ts:35 Uncaught TypeError: Cannot read property 'childNodes' of undefined
at applyPatch (patch.ts:35)
at Array.map (<anonymous>)
at Function.handle (patch.ts:18)
at WebSocket.<anonymous> (socket.ts:49)
from live.
Hi, oops I will have a look
from live.
This should be fixed now. It was a diff case I hadn't thought about, and I hadn't checked the form example in a while, Please try the new release. Thanks!
from live.
The original issue is now fixed, so that it retains the input value when toggling the error message. But I see that it still hits the same error in the console after submitted the 3rd time. Does that happen for you as well?
from live.
I didn't see that, but I will have another look.
Thanks for finding these!
from live.
Ok I think I see it in an old version. If the range of <pre>
tags are being output without being wrapped in a container i see the error message. Temp fix is to just wrap them in a container like they are on master.
Issue is to do with how the server side diff function is dealing with white space. I'm trying to figure out a fix now, I will get back to you
from live.
@justinfx Ok please try the latest master or v0.2.1
and see if it is fixed for you. Thanks
from live.
Works great now. Thanks!
from live.
just tried the ToDo list example on firefox 83.0
seems like it's still producing console errors:
WebSocket Disconnected code: 1001, reason: live.js:1:7184
Cookie “session-name” has been rejected because a non-HTTPS cookie can’t be set as “secure”. form
Socket.dial called socket.ts:18:16
GEThttp://10.139.71.29:8081/favicon.ico
[HTTP/1.1 404 Not Found 0ms]
Uncaught TypeError: e.getAttribute is not a function
hook element.ts:31
getElementHooks event.ts:150
beforeDestroy event.ts:98
applyPatch patch.ts:59
handle patch.ts:18
dial socket.ts:51
dial socket.ts:43
w live.ts:12
<anonymous> auto.ts:16
EventListener.handleEvent* auto.ts:11
<anonymous> auto.ts:16
element.ts:31:23
Uncaught TypeError: e.getAttribute is not a function
hook element.ts:31
getElementHooks event.ts:150
beforeDestroy event.ts:98
applyPatch patch.ts:59
handle patch.ts:18
dial socket.ts:51
dial socket.ts:43
w live.ts:12
<anonymous> auto.ts:16
EventListener.handleEvent* auto.ts:11
<anonymous> auto.ts:16
element.ts:31:23
Uncaught TypeError: e.getAttribute is not a function
hook element.ts:31
getElementHooks event.ts:150
beforeDestroy event.ts:98
applyPatch patch.ts:59
handle patch.ts:18
dial socket.ts:51
dial socket.ts:43
w live.ts:12
<anonymous> auto.ts:16
EventListener.handleEvent* auto.ts:11
<anonymous> auto.ts:16
element.ts:31:23
Uncaught TypeError: e.getAttribute is not a function
hook element.ts:31
getElementHooks event.ts:150
beforeDestroy event.ts:98
applyPatch patch.ts:59
handle patch.ts:18
dial socket.ts:51
dial socket.ts:43
w live.ts:12
<anonymous> auto.ts:16
EventListener.handleEvent* auto.ts:11
<anonymous> auto.ts:16
element.ts:31:23
cc @threeaccents
from live.
@c-nv-s try latest master or release v0.2.5
.
It appears Firefox doesn't have getAttribute
defined everywhere. Should be fixed now
from live.
Actually found another bug off the back of that, again appears to be just firefox
from live.
@c-nv-s Ok now Firefox works, thanks for the headsup
from live.
v0-2-5 firefox 83.0 - console errors resolved if you ignore duplicating 'submit query' button
I don't have screenkey enabled but I can assure you I'm not pressing Enter during this demo:
from live.
from live.
Oh try v0.2.6
that's where the fix for that is
from live.
v0-2-6-issue06-02.gif firefox 83.0 : as far i'm concerned this ticket is resolved for firefox.
As you have also noticed there is hesitation to connect to the websocket, and I initially receive a series of connection not ready errors, however that's for a separate ticket.
connection not ready for send of event Object { t: "validate", d: {…} } socket.ts:62:20
from live.
Great, thanks!
from live.
Related Issues (17)
- Client always using ws protocol HOT 2
- Firefox websocket is slow to connect HOT 2
- examples/clock: works with Firefox but not Chrome HOT 8
- internal errors cause JSON marshal error HOT 1
- Button example has patch error HOT 6
- Render on client HOT 6
- Chatgroup for this project. HOT 3
- Invalid renderings HOT 3
- Details is always closed whenever the DOM is patched HOT 2
- fix to build on mac, and maybe other OS's HOT 1
- File uploads HOT 3
- PatchURL for full path - not only query params HOT 4
- How to read URL query string params in HandleMount? HOT 3
- Broadcasting events on global level? HOT 3
- Integration with Fiber HOT 2
- baseEngine.handleEmittedEvent not fully synced HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from live.