examples/form: losing current input value during validation about live

[justinfx]

Actually, I realized I am getting a console error from that example at the moment when the characters reach 10:

patch.ts:35 Uncaught TypeError: Cannot read property 'childNodes' of undefined
    at applyPatch (patch.ts:35)
    at Array.map (<anonymous>)
    at Function.handle (patch.ts:18)
    at WebSocket.<anonymous> (socket.ts:49)

[jfyne]

Hi, oops I will have a look

[jfyne]

This should be fixed now. It was a diff case I hadn't thought about, and I hadn't checked the form example in a while, Please try the new release. Thanks!

[justinfx]

The original issue is now fixed, so that it retains the input value when toggling the error message. But I see that it still hits the same error in the console after submitted the 3rd time. Does that happen for you as well?

[jfyne]

I didn't see that, but I will have another look.

Thanks for finding these!

[jfyne]

Ok I think I see it in an old version. If the range of <pre> tags are being output without being wrapped in a container i see the error message. Temp fix is to just wrap them in a container like they are on master.

Issue is to do with how the server side diff function is dealing with white space. I'm trying to figure out a fix now, I will get back to you

[jfyne]

@justinfx Ok please try the latest master or v0.2.1 and see if it is fixed for you. Thanks

[justinfx]

Works great now. Thanks!

[c-nv-s]

just tried the ToDo list example on firefox 83.0
seems like it's still producing console errors:

WebSocket Disconnected code: 1001, reason: live.js:1:7184
Cookie “session-name” has been rejected because a non-HTTPS cookie can’t be set as “secure”. form
Socket.dial called socket.ts:18:16
GEThttp://10.139.71.29:8081/favicon.ico
[HTTP/1.1 404 Not Found 0ms]

Uncaught TypeError: e.getAttribute is not a function
    hook element.ts:31
    getElementHooks event.ts:150
    beforeDestroy event.ts:98
    applyPatch patch.ts:59
    handle patch.ts:18
    dial socket.ts:51
    dial socket.ts:43
    w live.ts:12
    <anonymous> auto.ts:16
    EventListener.handleEvent* auto.ts:11
    <anonymous> auto.ts:16
element.ts:31:23
Uncaught TypeError: e.getAttribute is not a function
    hook element.ts:31
    getElementHooks event.ts:150
    beforeDestroy event.ts:98
    applyPatch patch.ts:59
    handle patch.ts:18
    dial socket.ts:51
    dial socket.ts:43
    w live.ts:12
    <anonymous> auto.ts:16
    EventListener.handleEvent* auto.ts:11
    <anonymous> auto.ts:16
element.ts:31:23
Uncaught TypeError: e.getAttribute is not a function
    hook element.ts:31
    getElementHooks event.ts:150
    beforeDestroy event.ts:98
    applyPatch patch.ts:59
    handle patch.ts:18
    dial socket.ts:51
    dial socket.ts:43
    w live.ts:12
    <anonymous> auto.ts:16
    EventListener.handleEvent* auto.ts:11
    <anonymous> auto.ts:16
element.ts:31:23
Uncaught TypeError: e.getAttribute is not a function
    hook element.ts:31
    getElementHooks event.ts:150
    beforeDestroy event.ts:98
    applyPatch patch.ts:59
    handle patch.ts:18
    dial socket.ts:51
    dial socket.ts:43
    w live.ts:12
    <anonymous> auto.ts:16
    EventListener.handleEvent* auto.ts:11
    <anonymous> auto.ts:16
element.ts:31:23

​cc @threeaccents

[jfyne]

@c-nv-s try latest master or release v0.2.5.

It appears Firefox doesn't have getAttribute defined everywhere. Should be fixed now

[jfyne]

Actually found another bug off the back of that, again appears to be just firefox

[jfyne]

@c-nv-s Ok now Firefox works, thanks for the headsup

[c-nv-s]

v0-2-5 firefox 83.0 - console errors resolved if you ignore duplicating 'submit query' button
I don't have screenkey enabled but I can assure you I'm not pressing Enter during this demo:

[jfyne]

Hmm that's just what I though I fixed... Let me try and replicate again

…

On Sun, 3 Jan 2021, 17:18 c-nv-s, ***@***.***> wrote: v0-2-5 firefox 83.0 - console errors resolved if you ignore duplicating 'submit query' button I don't have screenkey <https://gitlab.com/screenkey/screenkey> enabled but I can assure you I'm not pressing Enter during this demo: [image: jfyne-live-v0-2-5-issue6] <https://user-images.githubusercontent.com/7495833/103484497-7d524c00-4def-11eb-8b74-8ab02b98a1f8.gif> — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADBXGKAXCIMUJKVGRIHGBTSYCRFVANCNFSM4VP6QTQQ> .

[jfyne]

Oh try v0.2.6 that's where the fix for that is

[c-nv-s]

v0-2-6-issue06-02.gif firefox 83.0 : as far i'm concerned this ticket is resolved for firefox.

As you have also noticed there is hesitation to connect to the websocket, and I initially receive a series of connection not ready errors, however that's for a separate ticket.

connection not ready for send of event  Object { t: "validate", d: {…} }      socket.ts:62:20

[jfyne]

Great, thanks!