Coder Social home page Coder Social logo

Button example has patch error about live HOT 6 CLOSED

jfyne avatar jfyne commented on July 26, 2024
Button example has patch error

from live.

Comments (6)

jfyne avatar jfyne commented on July 26, 2024 1

Glad that fixed it, but disabling the extension is a workaround. I imagine this is going to happen with a lot of extensions.

I will have a think about how to find the correct node to update in a less brittle way. I have a couple of ideas which I will experiment with soon. The advantage Phoenix has is their templates are aware of what can be updated, this implementation is unaware.

And yes contributions are welcome

from live.

jfyne avatar jfyne commented on July 26, 2024

@AnaelBerrouet this project in its current form is not very idiomatic in the Go sense, I pretty much lifted the API from phoenix. I think I might take another pass at it to make it more "Go", and especially when generics show up soon it will be worth another pass.

from live.

AnaelBerrouet avatar AnaelBerrouet commented on July 26, 2024

In chrome theres the extra script node for that chrome extension

DOM structure in chrome (patch non-functional):
Screen Shot 2021-10-24 at 12 25 15 PM

DOM structure in safari (patch functional):
Screen Shot 2021-10-24 at 12 26 44 PM

from live.

AnaelBerrouet avatar AnaelBerrouet commented on July 26, 2024

So i disabled Apollo Client Devtools which was injecting that added script. And the page is fully functional again!
thanks for taking the time to help me out on this.

Slight aside, are you open to code contributions? I wouldn't mind diving into this code base and helping out if I can at some point. Either way, thanks again!

from live.

AnaelBerrouet avatar AnaelBerrouet commented on July 26, 2024

Nvm just saw your contributing.md!

from live.

jfyne avatar jfyne commented on July 26, 2024

Closing this as fixed in https://github.com/jfyne/live/releases/tag/v0.11.0

from live.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.