jfitisoff / insite Goto Github PK

Need to review auto-generation routines for element wrapper classes and element accessors for basic DOM elements:

• Double-check to see if anything is getting missed.
• Review test coverage.

E.g., Watir::Window

When there are pages with the following URL definitions:

set_url "/accounts{account_code}"
set_url "/accounts/new"

The wrong page can potentially be selected, depending on which URL template is matched first. URL matchers are the current solution for this but defining the right regular expression can sometimes be a little tricky. It shouldn't be that hard to do some additional analysis above and beyond a straight template match, which should mostly eliminate the need to specify a URL matcher.

Create a browser wrapper class with support for all of the element and component methods. Create a separate method for returning the watir browser.

• @ngcontent and @Nghost
• Finish support for non_relative argument for element/component definitions.
• Packaging.

Use the inherited callback (may just need for page classes)

The error shown below is raised when a nonexistent page accessor method is called and the site is on an undefined page. An error actually should be raised here but the current one isn't helpful. Need a better one.

[1] pry(main)> s.landing_page
NoMethodError: Could not apply landing_page. The current page could not be recognized. Current URL data:,
from /Users/john/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/insite-0.1.3/lib/insite/insite.rb:267:in `method_missing'
[2] pry(main)> s.page
=> #<Insite::UndefinedPage:0x00007fea71a297f8
 @browser=#<Watir::Browser:0x..f97027514995b2c44 url="data:," title="">,
 @site=#<Omni:0x70322449466460
 @base_url="###################" @most_recent_page=>,
 @url="data:,">