jethornton / jt-logger Goto Github PK

Fix when log is requested that a log is built first

Traceback (most recent call last):
File "jt-logger.py", line 428, in
main()
File "jt-logger.py", line 421, in main
bot.start()
File "/home/tom-itx/src/logbot/ircbot.py", line 247, in start
SimpleIRCClient.start(self)
File "/home/tom-itx/src/logbot/irclib.py", line 1114, in start
self.ircobj.process_forever()
File "/home/tom-itx/src/logbot/irclib.py", line 229, in process_forever
self.process_once(timeout)
File "/home/tom-itx/src/logbot/irclib.py", line 214, in process_once
self.process_data(i)
File "/home/tom-itx/src/logbot/irclib.py", line 183, in process_data
c.process_data()
File "/home/tom-itx/src/logbot/irclib.py", line 600, in process_data
self._handle_event(Event(command, prefix, target, arguments))
File "/home/tom-itx/src/logbot/irclib.py", line 604, in _handle_event
self.irclibobj._handle_event(self, event)
File "/home/tom-itx/src/logbot/irclib.py", line 325, in _handle_event
if handler[1](connection, event) == "NO MORE":
File "/home/tom-itx/src/logbot/irclib.py", line 1049, in _dispatcher
getattr(self, m)(c, e)
File "jt-logger.py", line 234, in on_part
if LOG_PART:self.format_event("part", event)
NameError: global name 'LOG_PART' is not defined

Log path needs to be in a public directory
Logger path needs to be in a private directory
LOG_LOCATION = 'http://server.no-ip.biz:82/~user/irc/logs/'
LOG_FOLDER = '/home/user/public_html/irc/logs/'

line 264 needs formatting
event.target() needs formatting

Something happened in freenode. Logger does not work anymore. While login and password are correct and irssi can log in correctly, the same login and password fails when used in jt-logger:

:NickServ!NickServ@services. NOTICE xxxxx :This nickname is registered. Please choose a different nickname, or identify via /msg NickServ identify .
:NickServ!NickServ@services. NOTICE xxxxx :Invalid password for xxxxx.

File "jt-logger.py", line 263
msg = msg.format(hm, , event.arguments()[0], person, self.user(event))

log header and date info missing from daily logs

builds the main index but not the # channel index's

how hard is it to add "AM" or "PM" on the timestamp since it's showing 12 hr format?

change to use full path.
def create_index(self, channel):
# delete the index if found
log_dir = os.getcwd()+'/logs'
index_path = os.path.join(log_dir, channel, 'index.html')

I am logging a channel on my IRC server. The channel is named '#obits'
Now, if someone else joins the channel using a command /join #OBITS
or say /join #ObItS
The logger crashes with an IOError.

  File "/srv/irclogger3/JT-Logger/jt-logger.py", line 236, in on_join
    if LOG_JOIN:self.format_event("join", event)
  File "/srv/irclogger3/JT-Logger/jt-logger.py", line 345, in format_event
    self.append_log_msg(date, channel, msg)
  File "/srv/irclogger3/JT-Logger/jt-logger.py", line 351, in append_log_msg
    self.create_log(log_path, channel)
  File "/srv/irclogger3/JT-Logger/jt-logger.py", line 361, in create_log
    with open(path, 'w') as log:
IOError: [Errno 2] No such file or directory: '/srv/www/irc_log_dir/#ObItS/2019-06-28.html'

We should perhaps be storing the channel we are supposed to log somewhere, and using that as the canonical name for generating the path of the logfile.

At least, we should not crash.