jessielw / deezy Goto Github PK

https://github.com/jlw4049/BHDStudio-DeeaW/blob/2b4a97ccd8ef044069b61da48409ffd682c0f050/packages/shared/shared_utils.py#L159

Low priority once things are stable

Just something to think about:

Basically there is no need to specify a temp dir. In my case I had not enough space left, so I have chosen an HDD and gladfully I have specified an empty folder, because this code look like: When a temp dir is set, delete everything in it, even subfolders. 😮

So in case you set --temp-dir="D:\" and forget to add --keep-temp everything will be lost, right?

https://github.com/jlw4049/DeeZy/blob/25224319d36b0f36fae98833fd40b2bd8ba2e782/deezy/audio_encoders/dee/dd.py#L181-L185

https://github.com/jlw4049/DeeZy/blob/25224319d36b0f36fae98833fd40b2bd8ba2e782/deezy/audio_encoders/dee/ddp.py#L176-L189

Path provided with input file exceeds path length for DEE.

DeeZy throws this error whenever I try to specify a temp directory with the "-tmp" switch.
If I use the default OS temp directory the command runs without issues.

If temp_dir is provided, creates a directory with that name instead of a randomly generated one.
If the length of the path to the input file plus the length of temp_dir exceeds 259 characters, raises a PathTooLongError.

The combined path length of my input file and temp directory does not exceed 259 characters. Here's the exact command I'm using:
deezy encode ddp -t 0 -b 1536 -k -tmp "H:\temp_deezy" -o "H:\deezy.eac3" "H:\input.mkv"

If I encode a Dolby Digital Plus 5.1 audiofile with a bitrate <384 kbit/s the produced file has always 384 kbit/s. Above 384 kbit/s everything is fine.
For example: I configure a bitrate of 320 kbit/s an the new file has a bitrate 384 kbit/s.

We can add some additional logic by checking count of all tracks (other than general) to ensure that audio is/isnt the only track in the file.

Additionally check the track data in media info lib, as we may be able to utilize streamids directly without the need for logic.

What about having a preferences file inside DeeZy directory to have custom dee and ffmpeg paths?

Currently it's only removing single spaces.

This will need to be remedied, can easily achieve this with regex.

We need to ensure all white space is removed from the filename

When you want to get help while dee.exe and/or ffmpeg.exe are not available, the help won't be printed:

.\deezy.exe -h
dee.exe path not found

Would be nice to get the (basic) help regardless the dependencies, because they are not required yet.

We'll utilize print and sys.exit()

Where we can pass in exit codes

Calculate it based off of audio track file size

https://github.com/jlw4049/BHDStudio-DeeaW/blob/arg-parse-adjustments/audio_encoder/info/__init__.py

Example: The.Jungle.Book.1967.BluRay.1080p.DTS-HD.MA.7.1.AVC.REMUX-FraMeSToR.mkv

Breaks on 5.1 encode but works for 2.0