jeroenwalter / managed-midi Goto Github PK

Seek() is implemented as a replay of all the midi messages from the start, while muting any note on/off requests. This allows for control changes and tempo changes to be done correctly.
It also mutes all channels before the replay.
However, it doesn't reset all controllers before the replay, so controllers like modulation and pitch will still have their last value.

When the player starts a new song, all controllers are reset. As the Seek operation basically is the same as starting a new song, it should also reset all controllers.

This will cause a divide by zero.
Result is that the music is played at ludicrous speed.

WaitBy blocks the calling thread for a specified duration in milliseconds.
This has the unfortunate consequence that if a midi event for instance has a delta time of 5 seconds, that the play thread is blocked for 5 seconds.
A Stop or Seek command will then be effectuated after those 5 seconds.
This can be solved by making IMidiPlayerTimeManager.WaitBy abortable or by having a different way of waiting the appropriate amount of time dictated by the delta time.