jeroennijhof / vncpwd Goto Github PK

when compiling few errors occur here is how to solve them (Not familiar with github so ill put them in Issues)
1:
replace: static u_char obfKey[8] = {23,82,107,6,35,78,88,7};
with: static unsigned char obfKey[8] = {23,82,107,6,35,78,88,7};
2:
add #include <stdint.h> to headers

During build there are warningsregarding using the "char" typed attributes where expected is "unsigned char":

+ /usr/bin/make -O -j4 'CFLAGS=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic'
gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -o vncpwd vncpwd.c d3des.c
vncpwd.c: In function 'decryptPw':
vncpwd.c:32:9: warning: pointer targets in passing argument 1 of 'des' differ in signedness [-Wpointer-sign]
     des(pPW, clrtxt);
         ^~~
In file included from vncpwd.c:24:0:
d3des.h:57:13: note: expected 'unsigned char *' but argument is of type 'char *'
 extern void des(unsigned char *, unsigned char *);
             ^~~
vncpwd.c:32:14: warning: pointer targets in passing argument 2 of 'des' differ in signedness [-Wpointer-sign]
     des(pPW, clrtxt);
              ^~~~~~
In file included from vncpwd.c:24:0:
d3des.h:57:13: note: expected 'unsigned char *' but argument is of type 'char *'
 extern void des(unsigned char *, unsigned char *);
             ^~~
vncpwd.c: In function 'main':
vncpwd.c:40:9: warning: unused variable 'c' [-Wunused-variable]
     int c;
         ^
vncpwd.c:53:5: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
     fread(pwd, 1024, 1, fp);
     ^~~~~~~~~~~~~~~~~~~~~~~
+ exit 0

Hi there, super cool program.

Would you mind giving some explanation or background as to how it works?

The main reason for this issue is that after I ran the program, it returned an encrypted password.

My vnc password is stored in /Library/vnc/vncpasswd so I ran the following command after making the files
./vncpwd /Library/vnc/vncpasswd

And it returned

Password: ?(NӬ??

Any thoughts as to why this is the output?

Hello,
Robert-André Mauchin noticed during the vncpwd package review for Fedora that the address of the Free Software Foundation in the source code and a README file is obsolete and potentially target to misuse.

The address should be:
Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301

Currently there is:
Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.

Best regards
Michal Ambroz

https://streamable.com/s0ar9z
https://streamable.com/wnm6df

here's some video when im trying to compile it using gcc and clang.
and nothing happen

Hello,
as code seems stable ... please would you consider tagging the release number?
It is kinda ugly according to packaging guidelise refer to git date and abreviation of the git commit number.
Thank you
Michal Ambroz

Hello,
please could you during build honor at least the CFLAGS settings ?
It would make packaging easier.

The license in vncpwd.c is GPLv2+ while the LICENSE file is GPLv3.
Did you meant to change the licensing of the vncpwd.c also to GPLv3 ?

Thank you
Michal Ambroz

According to the license information for the project there should be a GPL license file but there is none. Please consider to add one. For reference, see also:

https://www.gnu.org/licenses/gpl-howto.en.html

Thank you.