jeremymickel / redhatfonts Goto Github PK

Getting this error message in afdko comparefamily

Error: font has OS/2.ulCodePageRange1 bit 29 not set, but the test heuristics say it should be set. .
Error: font has OS/2.ulUnicodeRange1 bit 3 set for Unicode block Latin Extended-B, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange1 bit 5 set for Unicode block Spacing Modifier Letters, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange1 bit 29 set for Unicode block Latin Extended Additional, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange1 bit 31 set for Unicode block General Punctuation, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange2 bit 33 set for Unicode block Currency Symbols, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange2 bit 35 set for Unicode block Letterlike Symbols, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange2 bit 37 set for Unicode block Arrows, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange2 bit 38 set for Unicode block Mathematical Operators, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange2 bit 62 set for Unicode block Alphabetic Presentation Forms, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange3 bit 67 set for Unicode block Arabic Presentation Forms-B, but the test heuristics say it should not be set. .
Error: font has OS/2.ulUnicodeRange3 bit 69 set for Unicode block Specials, but the test heuristics say it should not be set. .

Getting these (seemingly contradictory) error messages

⚠ WARN: Check mark characters are in GDEF mark glyph class)
com.google.fonts/check/gdefspacingmarks
--- Rationale ---
Glyphs in the GDEF mark glyph class should be non-spacing. Spacing glyphs in the GDEF mark glyph class may have incorrect anchor positioning that was only intended for building composite glyphs during design.

⚠ WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake: acute, breve, caron, cedilla, circumflex, commaaccent, dieresis, dotaccent, grave, hungarumlaut and 4 more. [code: spacing-mark-glyphs]
⚠ WARN: Check GDEF mark glyph class doesn't have characters that are not marks)
com.google.fonts/check/gdefnonmark_chars
--- Rationale ---
Glyphs in the GDEF mark glyph class become non-spacing and may be repositioned if they have mark anchors. Only combining mark glyphs should be in that class. Any non-mark glyph must not be in that class, in particular spacing glyphs.

⚠ WARN The following non-mark characters should not be in the GDEF mark glyph class: U+0060, U+00A8, U+00AF, U+00B4, U+00B8, U+02C6, U+02C7, U+02D8, U+02D9, U+02DA, U+02DB, U+02DC and U+02DD [code: non-mark-chars]

Fontbakery is reporting a FAIL for Panose being mismatched between Proportional and Mono fonts

🔥 FAIL PANOSE proportion is not the same across this family. In order to fix this, please make sure that the panose.bProportion value is the same in the OS/2 table of all of this family font files. [code: inconsistency]

Fontbakery also reports a FAIL for Monospace Panose not being correct. When I open the TTF / OTF files, Panose is not included. Let's include in the build script.

🔥 FAIL On monospaced fonts, the value of OS/2.panose.bProportion must be set to 9 (proportion: monospaced), but got 0 instead. [code: mono-bad-panose-proportion]

Style linking (regular to bold) doesn't work with STAT table format 2. Therefore we don't put ranges in weight axis anymore.

We will just send the variable font to GF and it must not contain VF in it.

It would make things easier if all formats were build from the same sources (VF, but named without VF), and eventually the statics could contain TT / OT in it to allow people to install the fonts from this repo on the same machine. You can use the script gftools rename-font in your build script to do so.

I've previously used a GOADB file to resolve working / final names for characters like Kcommaaccent.

Possible to reference a GOADB file for this workflow?

example:

uni0136	Kcommaaccent	uni0136
Lacute	Lacute	uni0139
Lcaron	Lcaron	uni013D
uni013B	Lcommaaccent	uni013B
Ldot	Ldot	uni013F
Lslash	Lslash	uni0141
Nacute	Nacute	uni0143
Ncaron	Ncaron	uni0147
uni0145	Ncommaaccent	uni0145

Unsure if the build-statics script is applying afdko autohint to OTF files.

like: https://github.com/Omnibus-Type/Texturina/blob/master/AUTHORS.txt

This is causing an error in afdko comparefamily

	Error: Missing Mac Postcriptname from name table! Should be in record (1, 0, 0, 6)
	Error: Missing Mac Compatible Family Name from name table! Should be in record (1, 0, 0, 1) 
	Error: Missing Mac Compatible SubFamily Name from name table! Should be in record (1, 0, 0, 2) 
	Error: Missing Mac Full Font Name from name table! Should be in record (1, 0, 0, 4) 
	Warning: Missing Mac Version String from name table! Should be in record (1, 0, 0, 5) 

Error: The  Mac and Windows Compatible Names for the regular face of a style-linked group should be the same. Font 
	Mac Compatible Name: 
	Windows Compatible Name: Red Hat Display

It's counting "Red Hat Display Black Regular" as the full name. I don't know why it's including "Regular". That's putting it over 27 characters.

⚠ WARN: Combined length of family and style must not exceed 27 characters.
com.google.fonts/check/name/familyandstylemaxlength
--- Rationale ---
According to a GlyphsApp tutorial [1], in order to make sure all versions of Windows recognize it as a valid font file, we must make sure that the concatenated length of the familyname (NameID.FONTFAMILYNAME) and style (NameID.FONTSUBFAMILYNAME) strings in the name table do not exceed 20 characters.

After discussing the problem in more detail at `FontBakery issue #2179 [2] we decided that allowing up to 27 chars would still be on the safe side, though.

[1] https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances [2] fonttools/fontbakery#2179

⚠ WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries: FONTFAMILYNAME = 'Red Hat Display Black' / SUBFAMILY_NAME = 'Regular'
Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

Hello!

This is an automatically-generated report about possible interpolation problems in RedHatDisplay[wght].ttf, as found in the Google Fonts catalog.

The particular version of the font that was tested was archive:.

To download a PDF version of this report with helpful visuals of the problems, click here; Or to view it on the GitHub website, click here.

The report follows:

Glyph degree was not compatible:
  Masters: '', 'wght=400.0122':
    Contour 0 start point differs: 0 in '', 18 in 'wght=400.0122'; reversed: False
    Contour 1 start point differs: 0 in '', 12 in 'wght=400.0122'; reversed: False

This report was generated using the fonttools varLib.interpolatable tool. We understand that sometimes the tool generates false-positives. Particularly for more complicated font designs. If you did not find this report useful, please apologize and ignore & close it.

To give feedback about this report, please file an issue or open a discussion at fonttools.