Comments (13)
BuildStatusChecksPublisher is the wrong place. You need PublishChecksStep.
from checks-api-plugin.
Hi @XiongKezhi, If this fix is not super urgent, can I work on this?
from checks-api-plugin.
go ahead! thanks!
from checks-api-plugin.
@XiongKezhi, is this issue fixed, or am I checking at the wrong place?
from checks-api-plugin.
Thanks, @KalleOlaviNiemitalo. To be clear, I shouldn't change the conclusion
variable's default value but need to add a condition to check whether status
is queued
or in_progress
, right?
from checks-api-plugin.
I don't really know what is the best way to implement this. Anyway, please test that the pipeline snippet generator behaves in a sensible way after your changes.
from checks-api-plugin.
Thanks, @KalleOlaviNiemitalo. To be clear, I shouldn't change the
conclusion
variable's default value but need to add a condition to check whetherstatus
isqueued
orin_progress
, right?
yes, you should add a condition to check the status when setting the conclusion.
from checks-api-plugin.
Ok sure. Thanks a lot, both of you.
from checks-api-plugin.
@XiongKezhi, could you please let me know if you have any guide to follow on setting up the plugin for local testing? I referred to the Consumers Guide and Implementation Guide, but it's a bit unclear for me. It would be better if you can help me with this.
from checks-api-plugin.
@ThusithaDJ Sorry, those are not guides for users, they are for other plugin developers.
So when you are trying to test this plugin locally, first you need to set up a Jenkins instance for remote debugging. If you are using a Jenkins war file, startup it with the java options like (for more, see here):
-Xdebug -Xrunjdwp:transport=dt_socket,address=127.0.0.1:8000,server=y,suspend=n
Then you can set up your remote debugger to attach to it.
Finally, you need a Jenkins project to run the code of this plugin:
- Set up the GitHub app credentials as in this guide
- Use the GitHub app credentials you added to Jenkins in the last step in one of your projects. I have a multi-branch project set up like this (you should use the repository that your GitHub app is installed on):
And since you are going to modify the publishChecks
step, so you should have a repository with a Jenkins pipeline calling publishChecks
.
from checks-api-plugin.
personally I just change the dependency in the github checks repo to a SNAPSHOT dependency, build this project with mvn install -P quick-build
and then run the github checks project with mvn hpi:run
using the debug option in my IDE
or just using unit tests for some changes where I don't actually need GitHub
from checks-api-plugin.
Hi @XiongKezhi, I have pushed some changes, please check that and let me know your thoughts.
#82
from checks-api-plugin.
fixed by #82
from checks-api-plugin.
Related Issues (20)
- Primary error message is not shown in error header, instead says `error in 'error' step` HOT 5
- Do not report handled exceptions HOT 3
- Build log Output truncated. - print tail of log instead of head HOT 2
- Allow using specific credentials for Checks HOT 5
- How do I create a custom rerun check in Pipeline HOT 1
- 1.7.5: download plugin checks-api to file: status code: 403, reason phrase: Forbidden HOT 2
- Phantom release 1.7.5 of checks-api HOT 1
- Possibility Of Specifying Credentials HOT 3
- Fix flaky test `BuildStatusChecksPublisherITest.shouldPublishStageDetails`
- [Question] Hanging checks with "withChecks()" HOT 5
- Include optional checks publisher to warnError HOT 1
- [doc] How to get started? HOT 5
- How to publish checks from sub-jobs HOT 1
- Dependency Dashboard
- Tests fail on Java 21 with Mockito errors HOT 2
- Setting Status checks name does not change it from the default Jenkins HOT 4
- Dependencies of flattened POM of latest release do not match `MANIFEST.MF`
- Return information about the check
- checks not working for Bitbucket scm HOT 1
- Steps with labels are not logged as errors HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from checks-api-plugin.