Primary error message is not shown in error header, instead says `error in 'error' step` about checks-api-plugin

[KalleOlaviNiemitalo]

The information about failing steps is formatted in FlowExecutionAnalyzer.java, so this issue belongs to jenkinsci/checks-api-plugin.

[justinmchase]

Also, the unstable step has the same issue:

Ideally it would show the actual message when in the unstable state as well.

[KalleOlaviNiemitalo]

Thank you, @timja.

UnstableStep adds a WarningAction.

ErrorStep just throws an AbortException. I guess that is then translated to ErrorAction somewhere in workflow-cps-plugin.

[KalleOlaviNiemitalo]

Should the formatting just special-case flowNode.getDisplayFunctionName() equal to "error" and "unstable", or is there a better way to decide whether the name and arguments of the step are uninteresting?

[KalleOlaviNiemitalo]

isStageNode already hardcodes the "stage" name, so hardcoding "error" and "unstable" as well would be consistent with that.

I imagine changes:

• In getPotentialTitle, if flowNode is an "error" step, then get whereBuildFailed from the first line of ErrorAction.getDisplayName() instead of formatting.
• In processErrorOrWarningRow, if flowNode is an "error" or "unstable" step, and there is only one argument, and its value matches errorAction.getDisplayName() or warningAction.getMessage(), then omit the step name and arguments from the output. Thus, if the "unstable" step somehow throws an actual error, then the step name and arguments would still be included.