Question: deterministic order of `ChecksPublisherFactory` execution about checks-api-plugin

[KalleOlaviNiemitalo]

Can we guarantee the order of the factories to make sure ours will be executed first ?

You could specify a high ordinal, e.g. @Extension(ordinal = 100000). I think that would let your factory be called first, especially if other implementations don't specify ordinals at all.

[XiongKezhi]

yes, that's a problem since we didn't expect there will be such a use case; we thought users will always use our implementation for GitSCM or GitHub Branch Source SCM (they are exclusive so the order is fine).

Now maybe making the ChecksPublisher comparable so that we can sort the stream before findFirst will solve the problem. We can make our implementation the lowest priority and the users' will be used first.

[timja]

or making it user selectable and hiding the choice if only one extension is available?
it's a reasonably common pattern,

Used in at least github api endpoints, fingerprinting, junit pluggable storage

[uhafner]

I think I have the same problem in my git-forensics plugin that tries to select reference builds (and mines repositories). It would make sense if we could use the same approach. The same happens if someone checks out from several repositories: I think we should make it possible to configure the repository (and use the first one if nothing has been configured). See jenkinsci/git-forensics-plugin#213

[agaudreault]

Thanks @KalleOlaviNiemitalo, I looked at the doc too quickly and never saw ordinal there! It seems like it will solve my usecase.

https://github.com/jenkinsci/jenkins/blob/d014a3159f2f4d5f7bfb6a1cb8867ed9b1fa5273/test/src/test/java/hudson/ExtensionListTest.java#L199-L208