Comments (6)
I follow your logic, if you think its fine to make it configurable I will try to follow up with a PR. It seems like this should be able to default to the current behavior and would be backwards compatible and would be a pretty reasonable thing to have configurable.
from checks-api-plugin.
Solved by #78 and jenkinsci/github-checks-plugin#124
from checks-api-plugin.
We marked the UNSTABLE as a failure because some users found that NEUTRAL may shadow the test failures: #11.
In Jenkins, plugins usually treat UNSTABLE as a failure, for example, the JUnit plugin will report UNSTABLE if one of the tests fails, and the Warnings-NG plugin uses UNSTABLE or FAILURE to conclude a build if it fails the quality gate.
It makes sense to make it configurable, you can implement it although it's a little complicated since it involves changes both on this API and the GitHub implementation:
- StatusChecksProperties is the extension point for SCM platform implementations to provide the status checks properties, it would retrieve properties from implementations according to the job, current we only provide name and skip-bility.
- GitHubStatusChecksProperties implements the above extension point for GitHub. Since we have both Git and GitHub project or SCM which target at GitHub, this class will get the user configurations from the proper GitHubStatusChecksConfigurations according to the SCM.
- And finally, GitHubSCMSourceStatusChecksTrait and GitSCMStatusChecksExtension implement GitHubStatusChecksConfigurations and provided configurations for the end users.
So, for this status, maybe define a getStatusMap
?
from checks-api-plugin.
Not sure if that can help for your usecase, but we sometime use the UNSTABLE
stageResult
instead of the buildResult
to display unstable behaviour that should not fail the build.
With that, the stage will show in yellow in the UI while the pipeline will still be successful.
catchError(message: "WARNING: The operation failed", buildResult: 'SUCCESS', stageResult: 'UNSTABLE', catchInterruptions: false) {
// steps that will throw an error, but not fail the build if they do
}
from checks-api-plugin.
@XiongKezhi does it still work? I've checked the Publish unstable builds as neutral status checks
checkbox but still getting failures in Github. Does even Github have neutral
check result? I only see passing, pending and failing in their docs.
from checks-api-plugin.
See https://docs.github.com/en/rest/checks/runs#create-a-check-run:
conclusion
Required if you provide completed_at or a status of completed. The final conclusion of the check. Note: Providing conclusion will automatically set the status parameter to completed. You cannot change a check run conclusion to stale, only GitHub can set this.
Can be one of: action_required, cancelled, failure, neutral, success, skipped, stale, timed_out
from checks-api-plugin.
Related Issues (20)
- .pom file uploaded for 1.7.1? HOT 1
- Multiple Github repo's / global pipeline libraries how do we control the repo to which the checks are reported HOT 14
- Primary error message is not shown in error header, instead says `error in 'error' step` HOT 5
- Do not report handled exceptions HOT 3
- Build log Output truncated. - print tail of log instead of head HOT 2
- Allow using specific credentials for Checks HOT 5
- How do I create a custom rerun check in Pipeline HOT 1
- 1.7.5: download plugin checks-api to file: status code: 403, reason phrase: Forbidden HOT 2
- Phantom release 1.7.5 of checks-api HOT 1
- Possibility Of Specifying Credentials HOT 3
- Fix flaky test `BuildStatusChecksPublisherITest.shouldPublishStageDetails`
- [Question] Hanging checks with "withChecks()" HOT 5
- Include optional checks publisher to warnError HOT 1
- [doc] How to get started? HOT 5
- How to publish checks from sub-jobs HOT 1
- Dependency Dashboard
- Tests fail on Java 21 with Mockito errors HOT 2
- Setting Status checks name does not change it from the default Jenkins HOT 4
- Dependencies of flattened POM of latest release do not match `MANIFEST.MF`
- Return information about the check
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from checks-api-plugin.