jellyfin / jellyfin-plugin-omdb

Jellyfin Open Movie Database Plugin

Part of the Jellyfin Project

About

This plugin adds the metadata provider for OMDb.

Installation

See the official documentation for install instructions.

Build

1. To build this plugin you will need .Net 5.x.

2. Build plugin with following command

dotnet publish --configuration Release --output bin

3. Place the dll-file in the plugins/omdb folder (you might need to create the folders) of your JF install

Releasing

To release the plugin we recommend JPRM that will build and package the plugin. For additional context and for how to add the packaged plugin zip to a plugin manifest see the JPRM documentation for more info.

Contributing

We welcome all contributions and pull requests! If you have a larger feature in mind please open an issue so we can discuss the implementation before you start. In general refer to our contributing guidelines for further information.

Licence

This plugins code and packages are distributed under the GPLv3 License. See LICENSE for more information.

jellyfin-plugin-omdb's Issues

Doesn't build with .NET 7.0

After installing .Net with brew install dotnet, I get .Net version 7. Unfortunately, it does not build with this release, and .Net version 5 is not available through Homebrew.

Is it not compatible with .Net version 7, or have I missed a step somewhere?

The linked JPRM instructions don't really tell me what to do, either — I don't know if they've changed since the README was written, but I was hoping it would be the equivalent of make.

Would it be possible to actually have a copy of the .dll in the repository so that people could just install it without having to build it themselves — or even have it in the official Jellyfin repo?

─▷ dotnet publish --configuration Release --output bin

Welcome to .NET 7.0!
---------------------
SDK Version: 7.0.100

----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only).
Learn about HTTPS: https://aka.ms/dotnet-https
----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
MSBuild version 17.4.0+18d5aef85 for .NET
  Determining projects to restore...
  Restored /Users/me/Development/jellyfin-plugin-omdb/Jellyfin.Plugin.Omdb/Jellyfin.Plugin.Omdb.csproj (in 5.39 sec).
  Restored /Users/me/Development/jellyfin-plugin-omdb/Jellyfin.Plugin.Omdb.Tests/Jellyfin.Plugin.Omdb.Tests.csproj (in 5.66 sec).
/Users/me/Development/jellyfin-plugin-omdb/Jellyfin.Plugin.Omdb/OmdbItemProvider.cs(12,27): error CS0234: The type or namespace name 'Json' does not exist in the namespace 'MediaBrowser.Common' (are you missing an assembly reference?) [/Users/me/Development/jellyfin-plugin-omdb/Jellyfin.Plugin.Omdb/Jellyfin.Plugin.Omdb.csproj]
/Users/me/Development/jellyfin-plugin-omdb/Jellyfin.Plugin.Omdb/OmdbProvider.cs(15,27): error CS0234: The type or namespace name 'Json' does not exist in the namespace 'MediaBrowser.Common' (are you missing an assembly reference?) [/Users/me/Development/jellyfin-plugin-omdb/Jellyfin.Plugin.Omdb/Jellyfin.Plugin.Omdb.csproj]

"The person's name was empty or null. "

Edit: Running 10.7 RC1 in portable mode on Windows 10.

Error appeared once it started scanning Tajkun TV Show

[06:40:58] [ERR] [34] MediaBrowser.Providers.TV.SeriesMetadataService: Error in The Open Movie Database
System.ArgumentException: The person's name was empty or null. (Parameter 'person')
   at MediaBrowser.Controller.Entities.PeopleHelper.AddPerson(List`1 people, PersonInfo person)
   at MediaBrowser.Providers.Plugins.Omdb.OmdbProvider.ParseAdditionalMetadata[T](MetadataResult`1 itemResult, RootObject result)
   at MediaBrowser.Providers.Plugins.Omdb.OmdbProvider.Fetch[T](MetadataResult`1 itemResult, String imdbId, String language, String country, CancellationToken cancellationToken)
   at MediaBrowser.Providers.Plugins.Omdb.OmdbItemProvider.GetMetadata(SeriesInfo info, CancellationToken cancellationToken)
   at MediaBrowser.Providers.Manager.MetadataService`2.ExecuteRemoteProviders(MetadataResult`1 temp, String logName, TIdType id, IEnumerable`1 providers, CancellationToken cancellationToken)