Comments (5)
I think it would be really great if an npm install classnames
provided us with an index.min.js
. That is pretty common practice. Yes it's tiny, but could be even tinier 🙂
from classnames.
I wrapped a simple try/catch around the export statement, not a proper solution but this way if it's included directly it'll expose a global classNames
function and not throw an error if module
is undefined.
from classnames.
Here's how I do it: https://github.com/chenglou/react-treeview/blob/master/react-treeview.jsx
Also, I don't usually provide a min inside repo too. Bower users will probably just add that to the list of things they need to minify anyways.
from classnames.
Started borrowing your code from react-treeview
but it's so much simpler because I don't need React defined, so I just changed it to a simple if (module && module.exports)
check. I think that covers enough cases and agree about magnification.
Feel free to open a PR if you've got a better way... otherwise, thanks :)
from classnames.
@marcfallows why?
I'd prefer a source code I can debug and let my own build system minify.
from classnames.
Related Issues (20)
- What is "cx" stand for? HOT 1
- Need support to append string in a class HOT 4
- unsupported ssg and ssr HOT 1
- Interface types aren't compatible in 2.3.2 HOT 4
- Throwing an exception when accessing non-existent classes HOT 2
- why not using one build tool for publish the npm package? HOT 2
- Incomplete type signature for classnames/bind HOT 2
- Advanced typing for classnames/bind HOT 4
- Explain to me about "cx" HOT 1
- Getting error says 'this' context of type 'void' is not assignable HOT 4
- [Question] When I used Object's value to computed key, what happened? HOT 2
- SyntaxError: Unexpected end of script (Mobile Safari) HOT 5
- When no classes are selected, classNames should return null HOT 5
- Vulnerable dependencies (indirect security issues) HOT 1
- How to erase or replace the properties of the conditional class from external component? HOT 1
- why number can be a className HOT 1
- Can we add exports field for this package? HOT 4
- Need a maintainer? HOT 7
- Preparing for version 3.0 HOT 9
- Should we support CommonJS for 3.0? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from classnames.