jednano / iso-http Goto Github PK

I'm using an API which specifies filters by passing the same URL parameter twice.

From reading the code, I'd need to provide an alternative implementation of serializeObject that could do this.

Would a PR to make hooking that possible be accepted?

Could you please add the browserify property to package.json to make it compatible to load with browserify?

When using browserify, one shouldn't have to do anything special to use the component in the browser other than install with npm.

To make this package compatible with browserify, I believe that you would simply add a browserify option to your package.json, specifying what to load for the browser (if it is different than for the server).

Since the current package.json only specifies main which is pointing to the node.js version, browserify tries to load that in the browser and it fails when making a request. Once you add the browserify property to package.json, you can have it load the appropriate browser version instead.

https://github.com/substack/node-browserify#packagejson

Thanks.

The x-requested-with header set in https://github.com/jedmao/iso-http/blob/master/lib/browser/Http.ts#L18 causes firefox to perform a CORS request where it otherwise wouldn't need to.

This adds ~100ms to XHR requests for mobile users. Does it make sense for clients that want this behavior to specify it themselves rather than baking it into the library?