jdobosz / testcafe-browser-provider-puppeteer Goto Github PK

In the closeBrowser method only the opened page gets closed. The browser process remains open and can prevent process termination in case of tests started through TestCafe API (e.g. gulp-testcafe). Puppeteer's browser.close() method should be called in the closeBrowser method to prevent this behavior.

node version 8.10
testcafe version 0.20

##Here is my issue

I have been using this package to run testcafe on a Jenkins server. It was working nicely but the Jenkins has been restructured. Now agents are generate via docker and these agents can't download chromium but do come with puppeteer and chromium pre-installed.

What I'd like to do is use this package but provide it an existing puppeteer or chromium as opposed to it downloading a new puppeteer every time we wish ti use it.

Version 1.3.2 of this has a dependency on 1.4.0 of Puppeteer. It worked just fine when I installed it a little over a week ago using 1.4 of Puppeteer. However new installs seem to be pulling 1.5.0 puppeteer which doesn't seem to work.

When running my tests I get:
14:36:56 ERROR: The process "9700" not found.
14:36:56 ERROR Was unable to open the browser "puppeteer:" due to error.
14:36:56
14:36:56 Error: Failed to launch chrome!
14:36:56 [0613/143656.027:ERROR:main_dll_loader_win.cc(134)] Failed to load Chrome DLL from \node_modules\puppeteer.local-chromium\win64-564778\chrome-win32\chrome.dll: The specified module could not be found. (0x7E)

When I run testcafe 1.3.3 with 1.4.0 of the browser provider, I get the following errors:

It seems this is only happening when I'm running testcafe in parallel and in quarantaine.

How can I get rid of these errors? They are making my tests fail all the time.

Settings:

use runner
.browsers(['puppeteer:no_sandbox'])

error: { Error: Was unable to open the browser "puppeteer:no_sandbox" due to error.

Error: WebSocket is not open: readyState 3 (CLOSED)

Hello!
My tests fails in headless chrome due to smaller window size than I have in regular chrome.
Is there any way to configure default window size?
Thanks

Hey folks! I’m the maintainer if Browserless (a docker/hosted service for puppeteer). I’d love to contribute to this repo instead of building it myself, and to that end I’m looking to add a remote connections as part of this plugin.

My first idea is to allow a remote URL in your provider string, similar to how you allow the path of the binary executable. Would just be a condition to check if that part of the string is a path or fully-qualified URL. Can do a quick PR if that helps!

What is your Scenario?

I'm trying to take screenshot of full page using takeScreenshot function with property fullPage: true (doc).
Unfortunately when I'm using puppeteer (with testcafe-browser-provider-puppeteer) it doesn't work. Screenshots still contain only visible in viewport part of page.

How to reproduce

I prepared repository, where you can reproduce my scenario. Repository contains simple test with custom browser provider - testcafe-browser-provider-puppeteer.

Steps:

1. Clone demo repository with git clone [email protected]:pfryga/testcafe-issue-poc.git
2. Install dependencies with npm ci
3. Run tests with npm run visual-regression
4. On message in terminal please open /Users/[...]/testcafe-issue-poc/screenshots/default/normal.png screenshot. For next 10 seconds created screenshot contains full page (proper behavior).
5. Execution of tests is purposely delayed for 10000 ms - for this time correct screenshot is created by puppeteer.
6. After 10000 ms Testcafe replaces created screenshot with corrupted one (non full page) - undesirable step

This issue has been reported before in Testcafe repository. Their research showed that the issue can be in the hasCustomActionForBrowser function, which is not overridden in the provider.
I have tried to override hasCustomActionForBrowser function in my fork of testcafe-browser-provider-puppeteer but it does not solve the problem.

What should I set in the provider to eliminate replacing a valid screenshot with a corrupted one?