I always say that writing successful tests is 25% coding and 75% writing. Code gets them to work. But 90% of the time people won't look at the code, they'll only see the writing. I try to imagine a non-developer reading my tests. Would they understand the language? If not, I try to write them better and clearer.

You test is definitely correct in what it does but I think "renders item properties" is not very understandable unless you know the code really well. I would use "renders a single item" or something similar that expresses that what we are testing is seeing an item with the correct info.

One thing I would have liked to see more is some comments, especially in the areas where it looks like you commented out some code? I wasn't sure why. Did the original block not work well? If so, why?

https://github.com/jdhines/gather-phase-4/blob/master/test/features/user-visits-create-test.js#L15-L18

Phantom is a bit tricky, so it's totally understandable you might have to try some things

I'm reviewing for codecademy. Great job on this! Your code does the job of testing this application really well.

Your code also indicates your have a great understanding of the material so far. I hope you are excited for the rest of the course because you are definitely ready for it!

Rubric

✅ = match
◻️ = see issue
💭 = comment
⭐ = extra credit

Model: Item
#title
✓ is a String ✅
✓ is required ✅
#description
✓ is a String ✅
✓ is required ✅
#imageUrl
✓ is a String ✅
✓ is required ✅

Server path: /
GET
GET / 200
✓ renders an item with a title and image ✅
GET / 200
✓ renders all items from the database ✅

Server path: /items/create
GET
GET /items/create 200
✓ renders empty input fields ✅
POST
POST /items/create 302
✓ creates and saves a new item ✅
POST /items/create 302
✓ redirects home ✅
POST /items/create 400
✓ displays an error message when supplied an empty title ✅
POST /items/create 400
✓ displays an error message when supplied an empty description ✅
POST /items/create 400
✓ displays an error message when supplied an empty imageUrl ✅

Server path: /items/:id
GET
GET /items/5a839f304febd859c09ec411 200
✓ renders a single item ◻️

15 passing (3s)

test/features/user-visits-create-test.js
User visits the create page
posts a new item
✓ and is rendered ✅

test/features/user-visits-root-test.js
User visits root
without existing items
✓ starts blank ✅
can navigate
✓ to the create page ✅
⭐ Also tests delete existing item

/test/features/user-visits-single-item-test.js

User navigates to /items/create
by clicking on a created item
✓ displays information on the item ✅

==================================================================
Number of specs: 3

4 passing