jdaniloc / biblecomment

A site to share the own comments about bible versicles. Made with React in the frontend, Express in the backend.

J. Danilo Carmo

See some private repositories here:

biblecomment's Issues

Refactor users table

Create a migration with follow changes:

• Rename name to username
• Remove token column and expires JWT token
• Remove total_comments column and use SQL Select instead
• Remove chapters_commented column and use SQL Select instead

Refactor comments component

This is an example of what it should look like

See the model in Figma

Implement search comments

Link by abbreviation and create a component to search comments using LIKE:

Don't forget to use debounce to improve the search performance.

(JS-0435) Avoid using `this.state` inside `this.setState()`

Description

It is recommended not to use this.state inside setState calls. Such usage of this.state might result in errors because if two setState operations are called, they will be grouped into a single update, which will evaluate the old state instead of the current state. This can be avoided by using …

Occurrences

There are 16 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/JDaniloC/Biblecomment/issue/JS-0435/occurrences/

Improve search

Can open in the exactly verse through:
Mt 10:20
Beucase will compare with the title from verses table

Be able to search by LIKE in comments or verses.

The user will choose the option as github do:

With the following options:

• No capítulo
• No versículo
• No comentário

(JS-0437) Prevent usage of Array index in keys

Description

Warn if an element uses an Array index in its key. The key is used by React to identify which items have changed, are added, or are removed and should be stable. It's a bad idea to use the array index since it doesn't uniquely identify your elements. In cases …

Occurrences

There are 4 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/JDaniloC/Biblecomment/issue/JS-0437/occurrences/

Version 3: Refactor header

It's necessary change the header following this model, where the oppened menus will be open over the page.

See the model in Figma

Migrate Heroku to Railway

Heroku free tier will no longer be available so its interesting to migrate to Railway or the full project to NextJS.

Refactor chapters table

Change Books table

• Alter table DROP primary key
• CREATE UNIQUE INDEX id ON books
• Alter table ADD primary key

Change Chapters table

• Create a new table called verses where will have:

ID	abbrev_id	chapter	verse	title	verse
0	gn	1	1	gn 1:1	No...
1	gn	1	2	gn 1:2	A t..
..	...	...	...	...	...
99	ap	22	5	ap 22:5	En...

• Export the verses from chapters table to verses table
• Drop chapters table

Favorites DB refactor

The current favorites DB structure is just a JSON array, but it's needed to be another table, like the comments.

(JS-0417) Avoid `.bind()` or Arrow Functions in JSX properties

Description

A bind call or arrow function in a JSX property will create a brand new function on every single render. This is bad for performance. <!--more--> This affects performance as it may cause unnecessary re-renders if a brand new function is passed as a property to a component that uses …

Occurrences

There are 40 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/JDaniloC/Biblecomment/issue/JS-0417/occurrences/

Refactor header v.2

Following the design below:

Link references

Create a chips container in each comment to link versicles.
It's interesting to show the float versicle when click the chip and have a button to go to the chapter.

(JS-0127) Found `undefined` as an Identifier

Description

The undefined variable in JavaScript is actually a property of the global object. As such, in ECMAScript 3 it was possible to overwrite the value of undefined. While ECMAScript 5 disallows overwriting undefined, it's still possible to shadow undefined, such as: ``` function doSomething(data) { var undefined = "hi"; // …

Occurrences

There are 33 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/JDaniloC/Biblecomment/issue/JS-0127/occurrences/

(JS-0048) Inconsistent newlines before and after dots

Description

JavaScript allows you to place newlines before or after a dot in a member expression. Consistency in placing a newline before or after the dot can greatly increase readability. #### Example - The not-preferred way : js var foo = object .property; #### Example - The preferred way : …

Occurrences

There are 149 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/JDaniloC/Biblecomment/issue/JS-0048/occurrences/

(JS-0463) Consider adding `propTypes` to the React component definition

Description

It is recommended to always add propTypes for a component as it avoids runtime errors. Using propTypes ensures valid properties being passed as props or being used as props.

Occurrences

There are 38 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/JDaniloC/Biblecomment/issue/JS-0463/occurrences/

Fetch comments when go to last page

• Use debouce strategy to avoid many requests
• Split the comments/favorites components
• Fetch comments when click in last page

DeepSource analysis

Perfomance

• Forbid certain props on Components
• Unnecessary return await function found

Anti-pattern

• Prefer boolean attributes notation in JSX
• Prevent extra closing tags for components without children

Bug risk

• Remove usage of undeclared variables
• Should not have unused variables
• Found usage of this outside of class or classes-like object
• Found invalid variable declaration
• Inconsistent use of the radix argument when using parseInt()
• Variable used before definition
• Detected unnecessary fragments
• Found await inside of loops

Chapter redesign

See in the Figma the new colors

(JS-0392) Inconsistent usage of destructuring assignment

Description

It is recommended to use destructuring assignment of props as it improves readability and creates shorter code and helps in refactoring as well.

Occurrences

There are 127 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/JDaniloC/Biblecomment/issue/JS-0392/occurrences/