jbrown215 / binah Goto Github PK

we need to generate select with Tagged. Here's the general template:

{-@ assume selectRECORDTagged :: forall <p :: User -> Bool>. f:[RefinedFilter<p> RECORD typ]
                -> [SelectOpt RECORD]
                -> Control.Monad.Trans.Reader.ReaderT backend m (Tagged<p> [Entity {v:RECORD | evalQsRECORD f v}]) @-}
selectRECORDTagged :: (PersistEntityBackend Friends ~ BaseBackend backend,
      PersistEntity RECORD, Control.Monad.IO.Class.MonadIO m,
      PersistQueryRead backend, PersistField typ) =>
      [RefinedFilter RECORD typ]
      -> [SelectOpt RECORD]
      -> Control.Monad.Trans.Reader.ReaderT backend m (Tagged [Entity RECORD])
selectRECORDTagged fs ts = do
  xs <- selectList (map toPersistentFilter fs) ts
  return (Tagged xs)

User
  username {v:Text | v != ""}

fails

binah: Error Line 2: username {v:Text | v != ""}
(line 1, column 29):
unexpected """

for example, if len UserEmail >0, then the string in the filter function for filterUserEmail needs to have the refinement that it is > 0, otherwise we get a liquid failure

We should probably be recording tests of some sort. A way to do this is to have an input and expected output and run diff on the expected vs actual output. Snapshot tests are somewhat annoying because they need to be re-recorded whenever the output style changes.

@jluningp, if you know of a better way to test than snapshots for this kind of thing, I'm happy to go into that. Otherwise, I'll try to figure out how to integrate snapshot tests + stack and I'll write a script to re-record all tests so that it doesn't get too annoying as we make changes.