Coder Social home page Coder Social logo

Comments (9)

chibash avatar chibash commented on June 23, 2024

Any idea to fix this? Is pom.xml broken?

from javassist.

merks avatar merks commented on June 23, 2024

I couldn't figure how how the MANIFEST.MF is being generated and hence I could not determine the source of the wrong information...

Is it generated from here?

javassist/pom.xml

Lines 220 to 244 in f74619e

<artifactId>maven-bundle-plugin</artifactId>
<version>3.3.0</version>
<executions>
<execution>
<id>bundle-manifest</id>
<phase>process-classes</phase>
<goals>
<goal>manifest</goal>
</goals>
</execution>
</executions>
<configuration>
<supportedProjectTypes>
<supportedProjectType>jar</supportedProjectType>
<supportedProjectType>bundle</supportedProjectType>
<supportedProjectType>war</supportedProjectType>
</supportedProjectTypes>
<instructions>
<Bundle-SymbolicName>${project.artifactId}</Bundle-SymbolicName>
<Bundle-Version>${project.version}</Bundle-Version>
<Import-Package>!com.sun.jdi.*</Import-Package>
<Export-Package>!com.sun.jdi.*,javassist.*;version="${project.version}"</Export-Package>
</instructions>
</configuration>
<extensions>true</extensions>

Or is it generated using this?

https://github.com/jboss-javassist/javassist/blob/master/build.xml

Both those files still have 3.29.2-GA so I'm really confused where 3.30.0-GA comes from and how it's built.

from javassist.

merks avatar merks commented on June 23, 2024

Cloning the repo and running the build produces this:

image

And that appears to be correct. I just don't know how the 3.30.0-GA versions is being created...

from javassist.

merks avatar merks commented on June 23, 2024

Maybe the problem is using an old version of this

https://repo1.maven.org/maven2/org/apache/felix/maven-bundle-plugin/3.0.0/

when this is the latest version:

https://repo1.maven.org/maven2/org/apache/felix/maven-bundle-plugin/5.1.9/

Maybe you are compiling for Java 11 or 17 and that old plugin don't recognize that?

from javassist.

laeubi avatar laeubi commented on June 23, 2024

And that appears to be correct

The pom.xml says the project is at Java 11

javassist/pom.xml

Lines 154 to 155 in f74619e

<source>11</source>
<target>11</target>

so it does not seem correct to say it is java 8.

from javassist.

chibash avatar chibash commented on June 23, 2024

My apology. The last commit has not been pushed.
Anyway, I used pom.xml and Java 21 to generate the 3.30.0-GA release.

from javassist.

chibash avatar chibash commented on June 23, 2024

Thanks, @merks You're right.

from javassist.

merks avatar merks commented on June 23, 2024

Thank you for publishing the new version immediately:

https://repo1.maven.org/maven2/org/javassist/javassist/3.30.1-GA/

from javassist.

merks avatar merks commented on June 23, 2024

Of course this can be closed now. Happy Holidays. 🎆

from javassist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.