Coder Social home page Coder Social logo

Comments (1)

shifujun avatar shifujun commented on July 21, 2024

This is definitely a bug. Just by looking at it, you can guess that it should most likely be changed like this:

                if (typeName == null)
                    kind = new NullType();
                else
                    kind = new ClassName(typeName);
                fixTypes1(scc, kind);

However, we shouldn't fix a bug without reproducible use cases. How to reproduce this scene is too difficult. I tried for a long time and couldn't construct this example.

Among the existing test cases, only test83StackmapWithArrayType can reproduce the scenario where cv.dimension is not equal to 0. But it is difficult to construct a situation where lowersSet is empty.

If you can provide an example of reproducing the bug, I believe it will be easy for us to submit a PR that can be incorporated.

————
translate from:
这肯定是一个Bug。简单看一下就可以猜到大概率应该这样改:

但是,我们不应该在没有复现用例的情况下修复一个bug。如何复现这个场景太难了,我试了好久都不能构造出这个例子。

现有都测试用例中只有test83StackmapWithArrayType可以复现cv.dimension不等于0的场景。但是很难构造出lowersSet是空的情况。

如果你能提供复现bug的例子,我相信我们很容易提一个可以合入的PR。

from javassist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.