jbikker / wrldtmpl8 Goto Github PK

Where can I get that file?

I wanted very badly to try this, but it seems tied to windows and to some extent visual studio (which I can't justify installing, unfortunately). I tried to hack at it myself (and submit a PR) but noticed it is not just a matter of modifying some ifdefs, as some windows API code is used.
The easy parts:

• adding ifdefs around use of windows.h.
• windows is case insensitive when looking for files, but it isn't the case on Unix based systems. #include <cl/cl.h> should be #include <CL/cl.h>.
• would be nice to have a makefile, but the project is simple enough.
• defining correct macros for glfw native, like GLFW_EXPOSE_NATIVE_X11, and using the appropriate context functions to pass ogl context to opencl.
• This may be ignorance on my part, but I got a lot of errors about <cstring> functions being used without being defined. An include may be missing or I made a mistake when trying to build.

There are some parts that would require actual work. The first I noticed is that windows API synchronization functions are used for jobs. An alternative would have to be provided if you intend to support other OSs.

Either way, thanks for sharing, it is valuable for study even if I can't see it in action right away.

Severity Code Description Project File Line Suppression State
Error C1041 cannot open program database 'C:\Users\janis\Downloads\WrldTmpl8-main\WrldTmpl8-main\x64\Debug\vc143.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS benchmark C:\Users\janis\Downloads\WrldTmpl8-main\WrldTmpl8-main\template\template.cpp 1

World.cpp is defining static const uint commitSize = BRICKCOMMITSIZE / 4 + gridSize;
Why the div by 4 ? I think this makes the commit buffer to small ? (commit buffer is commit in code, not commitBuffer (not used anymore?))

I added some quick&dirty frame-sliced commits (only upload MAXCOMMITS each frame, remaining are done next frames) so I don't have to bump the MAXCOMMITS exponential.

This however leads to a crash during StreamCopy (during World::Commit, dst pointer is not writable) and I believe this is due the buffer not allocated big enough to actually hold MAXCOMMITS bricks+Indices?

Quickly inspecting it I wonder why this div by 4 is done.
Not doing that div works but it could be just masking the symptoms ?

OpenCL compilation of trace.cl fails on the current master

file cl/trace.cl, line 80, pos 35:
Explicit cast from address space "global" to address space "private" is not allowed

that points to line:

if (p != lp) page = (PAYLOAD*)bricks[v / (CHUNKSIZE / PAYLOADSIZE)], lp = p;

errorlog.txt

My runtime:

available OpenCL platforms:
#0: NVIDIA CUDA
OpenCL device: NVIDIA CUDA
Device # 0, GeForce RTX 2070 (OpenCL 1.2 CUDA)
Allocated 8MB on CPU and GPU for the top-level grid.
Allocated 512MB on CPU and GPU for 1024k bricks.
Allocated 32KB on CPU for bitfield.
Allocated 4MB on CPU for brickInfo.