javorske / calculator

Calculator

Simple console application created for educational purposes.

Created with:

• Visual Studio Community 2017

Used programming languages:

• C#

Functionalities:

This program sums, subtracts, multiplies and divides two decimal numbers.

How it works?

1. Choose from 1 to sum, 2 to subtract, 3 to multiply or 4 to divide your numbers. Type your choice and confirm by pressing "enter".
2. Type in your first number and press "enter".
3. Type in your second number and press "enter".
4. The result of your mathematical operation will be displayed in Console.
5. To calculate once again, press "enter".
6. To close application type "0" and press "enter". If you type in wrong number or character, console will display information about it and will go back to main menu.

calculator's Issues

#1 Odejmowanie

odejmowanie w menu

Missing readme

There is no readme file for this project

Some files, e.g. binary ones, should not be kept in git

Currently git tracks all files, even .exe, .dll and other files produced by compilator.
They should be ignored by git (use .gitignore file)

dsds

dsds

Improve handling of incorrect user input

Current solution does not handle ArgumentNullException and OverflowException (in fact, it handles only FormatException).

It's better to use int.TryParse, which allows to have more control over the user input. try-catch is not necessary - it makes the code less comprehensible.

Improve .csproj file

Current .csproj file is way too complicated:
https://github.com/javorske/Calculator/blob/master/Calculator/Calculator.csproj

It's much easier to work with SDK style projects:
http://hermit.no/moving-to-sdk-style-projects-and-package-references-in-visual-studio-part-2/

Missing unit tests

There are no unit tests.

Client and backend logic mixed in one project

Client (console app) and backend logic are mixed in one project now.
They should be kept in separate assemblies.

Project uses .NET framework which is abandoned by Microsoft

.NET framework is no longer developed by Microsoft and as such should be avoided.
Migrate whole solution to .NET Core (or even better - to .NET 5)

Project file and folder names still in polish

The following names should be in english:

Division

bla bla

Multiplication

Add multiplication to menu and method that multiplies two numbers

Duplicated code

Strategy pattern not fully implemented in Program.cs

Interface and concrete classes have been created, but Program.cs does not utilize polymorphism:

No need to create separate variable for each case in switch - just declare variable of IMathOperation type before switch and call MathOperation() after switch.
Use switch only to assign a concrete implementation of IMathOperation to the variable.

dsdsdsdsw

wdwdqd