javierbrea / node-sass-alias-importer Goto Github PK

Describe the bug

The 9486588 commit attempts to add path support presumably to support Windows environments.

However this leads to aliases no longer working because most scss imports use @import "foo/bar"; rather than @import "foo\\bar"; which is what the code would be checking on Windows.

The fix for that is this:

--- if (!aliasFound && url.split(path.sep)[0] === aliasDetails.alias) {
+++ if (!aliasFound && url.split('/')[0] === aliasDetails.alias) {

To Reproduce
Run a test on a windows environment.

Expected behavior
The alias is updated.

Operating system, Node.js an npm versions, or browser version (please complete the following information):

• OS: Windows 10
• Node.js: v12.2.0
• npm: 6.9.0

The link to the LICENSE file in the README is broken.
The .md extension has to be removed from the LICENSE link to make it work.

Node LTS at the time I'm writing this issue is 16.13.0
The currently supported node versions are 10, 11, 12, 14 and 15, but the module works fine with Node 16.

It is desirable to add mutation tests using Stryker

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update endbug/version-check action to v2.1.4
• chore(deps): update mindsers/changelog-reader-action action to v2.2.3
• chore(deps): update dependency eslint to v8.57.0
• chore(deps): update dependency eslint-config-prettier to v9.1.0
• chore(deps): update dependency eslint-plugin-prettier to v5.1.3
• chore(deps): update dependency lint-staged to v15.2.2
• chore(deps): update dependency prettier to v3.2.5
• chore(deps): update actions/cache action to v4
• chore(deps): update actions/setup-node action to v4
• chore(deps): update dependency eslint to v9
• chore(deps): update dependency husky to v9
• chore(deps): update github artifact actions to v4 (major) (actions/download-artifact, actions/upload-artifact)
• 🔐 Create all rate-limited PRs at once 🔐

Pending Status Checks

These updates await pending status checks. To force their creation now, click the checkbox below.

• chore(deps): update martinbeentjes/npm-get-version-action action to v1.3.1

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update actions/checkout action to v4

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

It is desirable to describe some alternatives in the documentation, as:

• Usage of webpack.resolve.alias

It is desirable to support the symbol ~ as as default alias, which should resolve to node_modules

In node-sass synchronous render mode, the done callback is not passed to the importer handler.
It is expected that the result will simply be returned from the handler.

Async mode: https://github.com/sass/node-sass/blob/master/lib/index.js#L324
Sync mode https://github.com/sass/node-sass/blob/master/lib/index.js#L403

Is your feature request related to a problem? Please describe.
Node-sass is deprecated, it will cause problema who is working with npm > 7 because the npm will auto install peer dependencies

Describe the solution you'd like
Remove node-sass from peer dependencies or add to optional dependencies

Describe alternatives you've considered
Remove node-sass from peer dependencies or add to optional dependencies

It is desirable to add E2E tests checking that the importer works as described in the documentation with both Webpack and Rollup.